Skip to content
Permalink
Branch: master
Commits on Apr 16, 2019
  1. perf(ivy): cache multiple reads to an element's stylingContext (#29818)

    matsko authored and alxhub committed Apr 10, 2019
    Because the styling context may be stored in a different location
    and be apart of a sub array, reading the styling context each time
    a host binding is evaluated is costly. This patch ensures that the
    active styling context is cached so that multiple interactions with
    styling bindings can easily retrieve the styling context efficiently.
    
    PR Close #29818
Commits on Apr 10, 2019
  1. perf(ivy): do not use spread operations in styling (#29795)

    matsko authored and IgorMinar committed Apr 9, 2019
    While investigating styling performance regressions, it was discovered
    that a single `fn(...args)` operation was causing a performance hit
    because the generated es5 `__spread` operation uses `[].concat` and
    reads from the `arguments` values (which are not very efficient). This
    patch changes that around to use `fn.apply` instead.
    
    PR Close #29795
Commits on Apr 8, 2019
  1. refactor(ivy): rename `styling_instructions` to `styling` (#29770)

    matsko authored and IgorMinar committed Apr 8, 2019
    PR Close #29770
  2. fix(ivy): add dev mode counter information to styling (#29579)

    matsko authored and IgorMinar committed Mar 28, 2019
    In order to optimize performance for styling-related operations in
    Angular, debug counters need to be introduced. This patch adds various
    counters to ngDevMode which are fired each time a styling-related
    binding is updated.
    
    PR Close #29579
Commits on Apr 5, 2019
  1. fix(ivy): ensure parent/sub-class components evaluate styling correct…

    matsko authored and IgorMinar committed Apr 2, 2019
    …ly (#29602)
    
    The new styling algorithm in angular is designed to evaluate host
    bindings stylinh priority in order of directive evaluation order. This,
    however, does not work with respect to parent/sub-class directives
    because sub-class host bindings are run after the parent host bindings
    but still have priority. This patch ensures that the host styling bindings
    for parent and sub-class components/directives are executed with respect
    to the styling algorithm prioritization.
    
    Jira Issue: FW-1132
    
    PR Close #29602
Commits on Mar 20, 2019
  1. docs: release notes for the v7.2.10 release

    matsko committed Mar 20, 2019
  2. release: cut the v8.0.0-beta.9 release

    matsko committed Mar 20, 2019
Commits on Mar 19, 2019
  1. build: add a nice Angular-themed color for the vscode status bar (#29407

    matsko committed Mar 19, 2019
    )
    
    PR Close #29407
  2. docs(ivy): add description for instructions directory structure (#29406)

    matsko committed Mar 19, 2019
    PR Close #29406
  3. fix(ivy): introduce host-specific styling instructions (#29292)

    matsko committed Mar 15, 2019
    This patch is the first of a few patches which separates the
    styling logic between template bindings (e.g. <div [style])
    from host bindings (e.g. @HostBinding('style')). This patch
    in particular introduces a series of host-specific styling
    instructions and changes the existing set of template styling
    instructions not to accept directives. The underyling code (which
    communicates with the styling algorithm) still works as it did
    before.
    
    This PR also separates the styling instruction code into a separate
    file and moves over all other instructions into an dedicated
    instructions directory.
    
    PR Close #29292
  4. revert: fix(core): parse incorrect ML open tag as text (#29328)

    matsko committed Mar 19, 2019
Commits on Mar 18, 2019
  1. revert: refactor(ivy): Update query-related comments (#29342)

    matsko committed Mar 18, 2019
Commits on Mar 15, 2019
  1. build: update to nodejs rules 0.27 (#29210)

    matsko committed Mar 15, 2019
    PR Close #29210
  2. revert: build: update to nodejs rules 0.27 (#29210)

    matsko committed Mar 15, 2019
    This reverts commit 08231f0.
Commits on Mar 14, 2019
  1. fix(ivy): ensure template styles/classes are applied before directive…

    matsko committed Mar 12, 2019
    …s are instantiated (#29269)
    
    Angular Ivy interprets inline static style/class attribute values as instructions that
    are processed whilst an element gets created. Because these inline style values are
    referenced by style/class bindings, their inline style values are applied at a later
    stage. Despite them being eventually applied, their values should be applied earlier
    before any directives are instantiated so that directive code can rely on any inline
    style/class changes.
    
    This patch ensures that all static style/class attribute values are applied (rendered)
    on the element before directives are instantiated.
    
    Jira Issue: FW-1133
    
    PR Close #29269
Commits on Mar 4, 2019
  1. fix(ivy): ensure static styling is properly inherited into child comp…

    matsko authored and AndrewKushnir committed Mar 1, 2019
    …onents (#29015)
    
    Angular supports having a component extend off of a parent component.
    When this happens, all annotation-level data is inherited including styles
    and classes. Up until now, Ivy only paid attention to static styling
    values on the parent component and not the child component. This patch
    ensures that both the parent's component and child component's styling
    data is merged and rendered accordingly.
    
    Jira Issue: FW-1081
    
    PR Close #29015
Commits on Mar 1, 2019
  1. test(animations): fix unit-based delays within the animation DSL (#28993

    matsko authored and AndrewKushnir committed Jan 16, 2019
    )
    
    Closes #24291
    
    PR Close #28993
Commits on Feb 27, 2019
  1. fix(animations): ensure `position` and `display` styles are handled o…

    matsko authored and benlesh committed Feb 21, 2019
    …utside of keyframes/web-animations (#28911)
    
    When web-animations and/or CSS keyframes are used for animations certain
    CSS style values (such as `display` and `position`) may be ignored by a
    keyframe-based animation. Angular should special-case these styles to
    ensure that they get applied as inline styles throughout the duration of
    the animation.
    
    Closes #24923
    Closes #25635
    
    Jira Issue: FW-1091
    Jira Issue: FW-1092
    
    PR Close #28911
Commits on Feb 20, 2019
  1. feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings (

    matsko authored and IgorMinar committed Feb 19, 2019
    #28711)
    
    Prior to this fix, both the `NgStyle` and `NgClass` directives made use
    of `Renderer2` and this dependency raised issues for future versions of
    Angular that cannot inject it. This patch ensures that there are two
    versions of both directives: one for the VE and another for Ivy.
    
    Jira Issue: FW-882
    
    PR Close #28711
  2. feat(ivy): open up ivy_switch_mode to non-core packages (#28711)

    matsko authored and IgorMinar committed Feb 1, 2019
    Prior to this fix, using the compiler's ivy_switch mechanism was
    only available to core packages. This patch allows for this variable
    switching mechanism to work across all other angular packages.
    
    PR Close #28711
Commits on Feb 14, 2019
  1. fix(ivy): ensure host bindings and host styling works on a root compo…

    matsko authored and mhevery committed Feb 12, 2019
    …nent (#28664)
    
    Prior to this fix if a root component was instantiated it create host
    bindings, but never render them once update mode ran unless one or more
    slot-allocated bindings were issued. Since styling in Ivy does not make
    use of LView slots, the host bindings function never ran on the root
    component.
    
    This fix ensures that the `hostBindings` function does run for a root
    component and also renders the schedlued styling instructions when
    executed.
    
    Jira Issue: FW-1062
    
    PR Close #28664
Commits on Feb 12, 2019
  1. feat(ivy): provide support for map-based host bindings for [style] an…

    matsko authored and mhevery committed Feb 8, 2019
    …d [class] (#28246)
    
    Up until now, `[style]` and `[class]` bindings (the map-based ones) have only
    worked as template bindings and have not been supported at all inside of host
    bindings. This patch ensures that multiple host binding sources (components and
    directives) all properly assign style values and merge them correctly in terms
    of priority.
    
    Jira: FW-882
    
    PR Close #28246
Commits on Feb 6, 2019
  1. revert: fix(ivy): remove query results from destroyed embedded views (#…

    matsko committed Feb 6, 2019
    …28445)
    
    This reverts commit 5ebc0da.
  2. release: cut the v8.0.0-beta.3 release

    matsko committed Feb 6, 2019
  3. docs: release notes for the v7.2.4 release

    matsko committed Feb 6, 2019
  4. build: add some debug info for yarn installs (#28553)

    matsko committed Feb 6, 2019
    PR Close #28553
Commits on Feb 5, 2019
  1. revert: build: switch to typescript's es2015 typings (#28134)

    matsko committed Feb 5, 2019
    This reverts commit dde7e2f.
  2. refactor(ivy): rename "blacklist" to "blocklist" (#28536)

    matsko committed Feb 5, 2019
    PR Close #28536
Commits on Feb 4, 2019
  1. revert: fix(ivy): remove query results from destroyed embedded views (#…

    matsko committed Feb 4, 2019
    …28445)
    
    This reverts commit 71b9d55.
Commits on Jan 31, 2019
  1. docs(ivy): update global utils documentation references to window.ng

    matsko committed Jan 31, 2019
Commits on Jan 25, 2019
  1. test(ivy): move error-handling test to be handled at a later stage (#…

    matsko authored and jasonaden committed Jan 17, 2019
    …28212)
    
    Due to the fast moving nature of the Ivy codebase, the timing isn't
    right to make changes to how errors and reported and handled during the
    runtime.
    
    Once ivy is stable this test should be revisted because that stage there
    will be a better and more robust understanding of how ivy should recover
    from runtime errors.
    
    Jira Issue: FW-952
    
    PR Close #28212
Commits on Jan 18, 2019
  1. fix(ivy): ensure animation component host listeners are rendered in t…

    matsko authored and alxhub committed Jan 17, 2019
    …he sub component (#28210)
    
    Due to the fact that animations in Angular are defined in the component metadata,
    all animation trigger definitions are localized to the component and are
    inaccessible outside of it. Animation host listeners in Ivy are
    rendered in the context of the parent component, but the VE renders them
    differently. This patch ensures that animation host listeners are
    always registered in the sub component's renderer
    
    Jira issue: FW-943
    Jira issue: FW-958
    
    PR Close #28210
Commits on Jan 17, 2019
  1. fix(ivy): ensure element removal triggers host removal animations (#2…

    matsko authored and alxhub committed Jan 14, 2019
    …8162)
    
    Prior to this fix Ivy would not execute any animation triggers
    that exist as host bindings on an element if it is removed by
    the parent template.
    
    PR Close #28162
  2. fix(ivy): ensure animation @trigger ordering is correctly delivered t…

    matsko authored and alxhub committed Jan 15, 2019
    …o the renderer (#28165)
    
    In Ivy when elements are created a series of static attribute names are provided
    over to the construction instruction of that element. Static attribute names
    include non-binding attribues (like `<div selected>`) as well as animation bindings
    that do not have a RHS value (like `<div @foo>`). Because of this distinction,
    value-less animation triggers are rendered first before value-full animation
    bindings are and this improper ordering has caused various existing tests to fail.
    This patch ensures that animation bindings are evaluated in the order that they
    exist within the HTML template code (or host binding code).
    
    PR Close #28165
Older
You can’t perform that action at this time.