[compiler-cli]: AOT build use @angular/forms/src/directives/number_value_accessor and cannot find it #12428

Closed
Delagen opened this Issue Oct 21, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@Delagen
Contributor

Delagen commented Oct 21, 2016

I'm submitting a ... (check one with "x")

[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
2.1.0 version does not include @angular/forms/src/directives/number_value_accessor in generated factories
2.1.1 include it but in genDir/node_modules/@angular... this file is missing

Expected behavior
Compiling as was

  • Angular version: 2.1.1
  • Language: Typescript 2.03
  • Node (for AoT issues): node --version = 6.9.1
@DzmitryShylovich

This comment has been minimized.

Show comment
Hide comment
@DzmitryShylovich

DzmitryShylovich Oct 21, 2016

Contributor

Can u pls provide repo with reproduction?

Contributor

DzmitryShylovich commented Oct 21, 2016

Can u pls provide repo with reproduction?

@SamVerschueren

This comment has been minimized.

Show comment
Hide comment
@SamVerschueren

SamVerschueren Oct 21, 2016

Contributor

Experiencing the same issue. It happens when you have a form element that has input type="number".

Contributor

SamVerschueren commented Oct 21, 2016

Experiencing the same issue. It happens when you have a form element that has input type="number".

@SamVerschueren

This comment has been minimized.

Show comment
Hide comment
@SamVerschueren

SamVerschueren Oct 21, 2016

Contributor

Created a repository that reproduces this bug.

https://github.com/SamVerschueren/angular2-number-value-accessor-bug

Contributor

SamVerschueren commented Oct 21, 2016

Created a repository that reproduces this bug.

https://github.com/SamVerschueren/angular2-number-value-accessor-bug

@vicb vicb added the comp: forms label Oct 21, 2016

@tbosch

This comment has been minimized.

Show comment
Hide comment
@tbosch

tbosch Oct 21, 2016

Member

This seems to be a duplicate of #11889. That previous bug was only about components. However, as we now also generate .ngfactory.ts files for directives, this bug becomes more severe.

Member

tbosch commented Oct 21, 2016

This seems to be a duplicate of #11889. That previous bug was only about components. However, as we now also generate .ngfactory.ts files for directives, this bug becomes more severe.

@Delagen

This comment has been minimized.

Show comment
Hide comment
@Delagen

Delagen Oct 22, 2016

Contributor

@tbosch No. it appear only in 2.1.1, before all works well, Number Value Accessor missing before 2.1.1 both in generated factories and in forms module

Contributor

Delagen commented Oct 22, 2016

@tbosch No. it appear only in 2.1.1, before all works well, Number Value Accessor missing before 2.1.1 both in generated factories and in forms module

vicb added a commit to vicb/angular that referenced this issue Oct 24, 2016

vicb added a commit to vicb/angular that referenced this issue Oct 24, 2016

@IgorMinar IgorMinar closed this in #12453 Oct 24, 2016

IgorMinar added a commit that referenced this issue Oct 24, 2016

@jbw91 jbw91 referenced this issue in ionic-team/ionic-app-scripts Nov 10, 2016

Closed

Build fail related to ngfactory #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment