feat(animations): support function types in transitions #13538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
force-pushed
the
transition_function
branch
from
3d5d135
to
5137ebc
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 17, 2016
matsko
force-pushed
the
transition_function
branch
from
5137ebc
to
3e7e34a
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 17, 2016
matsko
force-pushed
the
transition_function
branch
from
3e7e34a
to
2a43709
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 17, 2016
matsko
force-pushed
the
transition_function
branch
from
2a43709
to
719f825
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 20, 2016
matsko
force-pushed
the
transition_function
branch
from
719f825
to
d01cc6b
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 21, 2016
matsko
force-pushed
the
transition_function
branch
from
d01cc6b
to
21a8a20
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 21, 2016
matsko
force-pushed
the
transition_function
branch
from
21a8a20
to
2c86eaf
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 21, 2016
matsko
force-pushed
the
transition_function
branch
from
2c86eaf
to
29f6e05
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 21, 2016
matsko
changed the title
matsko
force-pushed
the
transition_function
branch
from
29f6e05
to
add63c1
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 3, 2017
mhevery
approved these changes
Jan 4, 2017
mhevery
added
action: merge
tbosch
reviewed
Jan 4, 2017
| @@ -16,7 +20,7 @@ import {AUTO_STYLE, Component, animate, state, style, transition, trigger} from | |||
| state('*', style({height: AUTO_STYLE, color: 'black', borderColor: 'black'})), | |||
| state('closed, void', style({height: '0px', color: 'maroon', borderColor: 'maroon'})), | |||
| state('open', style({height: AUTO_STYLE, borderColor: 'green', color: 'green'})), | |||
| transition('* => *', animate(500)) | |||
There was a problem hiding this comment.
Could you keep the old transition and add another one?
There was a problem hiding this comment.
I.e. just make another transition?
tbosch
reviewed
Jan 4, 2017
| @@ -8,6 +8,10 @@ | |||
|
|
|||
| import {AUTO_STYLE, Component, animate, state, style, transition, trigger} from '@angular/core'; | |||
|
|
|||
| export function anyToAny(stateA: string, stateB: string): boolean { | |||
| return true; | |||
There was a problem hiding this comment.
Could you add a simple condition in here?
tbosch
reviewed
Jan 4, 2017
| @@ -49,6 +49,10 @@ export class AnimationStateTransitionExpression { | |||
| constructor(public fromState: string, public toState: string) {} | |||
| } | |||
|
|
|||
| export class AnimationStateTransitionFnExpression extends AnimationStateTransitionExpression { | |||
| constructor(public fn: Function) { super(null, null); } | |||
There was a problem hiding this comment.
The correct type is Function | StaticSymbol
tbosch
reviewed
Jan 4, 2017
| const stateChangeExpr = transitionStateMetadata.stateChangeExpr; | ||
| const transitionStates: Array<Function|string> = typeof stateChangeExpr == 'string' ? | ||
| (<string>stateChangeExpr).split(/\s*,\s*/) : | ||
| [<Function>stateChangeExpr]; |
There was a problem hiding this comment.
Type cast: <Function|StaticSymbol>
tbosch
reviewed
Jan 4, 2017
| @@ -39,7 +39,11 @@ export class CompileAnimationStateDeclarationMetadata extends CompileAnimationSt | |||
| } | |||
|
|
|||
| export class CompileAnimationStateTransitionMetadata extends CompileAnimationStateMetadata { | |||
| constructor(public stateChangeExpr: string, public steps: CompileAnimationMetadata) { super(); } | |||
| constructor( | |||
| public stateChangeExpr: string|((stateA: string, stateB: string) => boolean), | |||
tbosch
added
action: cleanup
matsko
force-pushed
the
transition_function
branch
from
add63c1
to
88d75c7
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 4, 2017
matsko
force-pushed
the
transition_function
branch
from
88d75c7
to
e618d4e
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 4, 2017
matsko
force-pushed
the
transition_function
branch
from
e618d4e
to
6200404
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Jan 4, 2017
tbosch
added
action: merge
matsko
force-pushed
the
transition_function
branch
from
6200404
to
be94928
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
idlechara
pushed a commit
to idlechara/angular
that referenced
this pull request
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13537