New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstractControl.markAsPending does not emit events #17958

Closed
ukyo opened this Issue Jul 6, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@ukyo
Copy link

ukyo commented Jul 6, 2017

I'm submitting a ...


[ ] Regression (behavior that used to work and stopped working in a new release)
[x] Bug report 
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

abstractControl.markAsPending() does not emit events.

Expected behavior

abstractControl.markAsPending() should emit 'PENDING'.

Minimal reproduction of the problem with instructions

For bug reports please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem via
http://plnkr.co/edit/BzGil9?p=preview

Please tell us about your environment


Angular version: 4.2.X

@ksvitkovsky

This comment has been minimized.

Copy link
Contributor

ksvitkovsky commented Aug 14, 2017

if no one is working on it, I take it 😊

@ksvitkovsky ksvitkovsky referenced this issue Aug 14, 2017

Closed

fix(forms): markAsPending to emit events #18676

2 of 3 tasks complete

Toxicable added a commit to Toxicable/angular that referenced this issue Nov 6, 2017

Toxicable added a commit to Toxicable/angular that referenced this issue Nov 6, 2017

Toxicable added a commit to Toxicable/angular that referenced this issue Nov 6, 2017

@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2018

Toxicable added a commit to Toxicable/angular that referenced this issue Feb 7, 2018

feat(forms): allow markAsPending to emit events
closes angular#17958

BREAKING CHANGE:
- `AbstractControl#statusChanges` now emits an event of `'PENDING'` when you call `AbstractControl#markAsPending`

Toxicable added a commit to Toxicable/angular that referenced this issue Feb 7, 2018

feat(forms): allow markAsPending to emit events
closes angular#17958

BREAKING CHANGE:
- `AbstractControl#statusChanges` now emits an event of `'PENDING'` when you call `AbstractControl#markAsPending`

Toxicable added a commit to Toxicable/angular that referenced this issue Feb 21, 2018

feat(forms): allow markAsPending to emit events
closes angular#17958

BREAKING CHANGE:
- `AbstractControl#statusChanges` now emits an event of `'PENDING'` when you call `AbstractControl#markAsPending`
- Previously it did not emit an event when you called `markAsPending`
- To migrate you would need to ensure that if you are filtering or checking events from `statusChanges` that you account for the new event when calling `markAsPending`

@vicb vicb closed this in e86b64b Feb 22, 2018

smdunn pushed a commit to smdunn/angular that referenced this issue Feb 28, 2018

feat(forms): allow markAsPending to emit events (angular#20212)
closes angular#17958

BREAKING CHANGE:
- `AbstractControl#statusChanges` now emits an event of `'PENDING'` when you call `AbstractControl#markAsPending`
- Previously it did not emit an event when you called `markAsPending`
- To migrate you would need to ensure that if you are filtering or checking events from `statusChanges` that you account for the new event when calling `markAsPending`

PR Close angular#20212

leo6104 added a commit to leo6104/angular that referenced this issue Mar 25, 2018

feat(forms): allow markAsPending to emit events (angular#20212)
closes angular#17958

BREAKING CHANGE:
- `AbstractControl#statusChanges` now emits an event of `'PENDING'` when you call `AbstractControl#markAsPending`
- Previously it did not emit an event when you called `markAsPending`
- To migrate you would need to ensure that if you are filtering or checking events from `statusChanges` that you account for the new event when calling `markAsPending`

PR Close angular#20212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment