Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Invalid property names in animation styles cause dom bug. #18701

Closed
realappie opened this Issue Aug 15, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@realappie
Copy link

commented Aug 15, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Making any typos in the styles function doesn't throw any run time errors. So invalid all CSS properties are completely fine. Beside that it creates a weird bug where the element is being duplicated over and over in the DOM.

Example:

Expected behavior

A run time error and no weird duplication on the element that's being animated.

Minimal reproduction of the problem with instructions

  1. Spam the only button on the page
  2. Thats it

Reproduction link

What is the motivation / use case for changing the behavior?

Its very hard to debug this weird animation bug if there is no error thrown. I made a typo and it took me longer than a month of searching and giving up to finally track the issue. Having any run time error or at least no weird DOM duplication bug would help a lot.

Environment


Angular version: 4.3.0 ( But issue was present in recent versions as well)


Browser:
- [x] Chrome (desktop) version 59
- [x] Firefox version 54
 

matsko added a commit to matsko/angular that referenced this issue Aug 15, 2017

matsko added a commit to matsko/angular that referenced this issue Aug 15, 2017

matsko added a commit to matsko/angular that referenced this issue Aug 16, 2017

matsko added a commit to matsko/angular that referenced this issue Aug 17, 2017

@matsko

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

This should land next week: #18718

@realappie

This comment has been minimized.

Copy link
Author

commented Aug 21, 2017

@matsko That was quick! Would you mind having a look at PR 17792? Its an animations bug fix which has been in the review process since June.

matsko added a commit to matsko/angular that referenced this issue Aug 21, 2017

matsko added a commit to matsko/angular that referenced this issue Aug 21, 2017

matsko added a commit to matsko/angular that referenced this issue Aug 21, 2017

@mhevery mhevery closed this in 409688f Aug 22, 2017

@Delagen

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2017

Seems it broke animation for prefixed browsers #18921, for example cannot use transform prefixed to ms and webkit to support all browsers for animation.

@mhevery

This comment has been minimized.

Copy link
Member

commented Sep 1, 2017

Please don't comment on closed issues, instead create new ones referring to this one. @matsko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.