New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested animation don't run and start callback is not fired #19100

Closed
lionelB opened this Issue Sep 7, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@lionelB

lionelB commented Sep 7, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

when 2 nested component with animation trigger defined on each component, only toplevel animation is run and its start animation callback is called.

Expected behavior

each callback should be called

Minimal reproduction of the problem with instructions

https://plnkr.co/edit/Wa7UNmKQkaVMWPNGmoxH?p=preview

What is the motivation / use case for changing the behavior?

Nested animation are usefull for defined enter animation

Environment


Angular version: 4.4.0-RC.0
 
Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [x] Firefox version XX
- [x] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
@matsko

This comment has been minimized.

Show comment
Hide comment
@matsko

matsko Sep 8, 2017

Member

The nested animation being prevented by the parent is by design (see this article to understand how to allow parent/child animations to run).

The start callback should be firing and it is a bug for sure. I will investigate.

Member

matsko commented Sep 8, 2017

The nested animation being prevented by the parent is by design (see this article to understand how to allow parent/child animations to run).

The start callback should be firing and it is a bug for sure. I will investigate.

@lionelB

This comment has been minimized.

Show comment
Hide comment
@lionelB

lionelB commented Sep 10, 2017

@matsko thanks !

@Bretto

This comment has been minimized.

Show comment
Hide comment
@Bretto

Bretto Sep 12, 2017

Is this related ? #17349

Bretto commented Sep 12, 2017

Is this related ? #17349

@bob-lee

This comment has been minimized.

Show comment
Hide comment
@bob-lee

bob-lee Sep 13, 2017

The nested animation being prevented by the parent is by design

@matsko I am applying slide-left animation on all route transitions including routes in lazy loaded module and all pages are sliding good. But for pages inside lazy loaded module, animateChild() doesn't seem to trigger pages' nested animation. Is this a known bug or am I missing something?

Edit on 22Nov17: I tested between 4.4.3 and 5.0.2 using this plnkr and noticed they behave a bit different:

  • 4.4.3 both route transition and nested animation work ok
  • 5.0.2 no route transition but only nested animation works ok

bob-lee commented Sep 13, 2017

The nested animation being prevented by the parent is by design

@matsko I am applying slide-left animation on all route transitions including routes in lazy loaded module and all pages are sliding good. But for pages inside lazy loaded module, animateChild() doesn't seem to trigger pages' nested animation. Is this a known bug or am I missing something?

Edit on 22Nov17: I tested between 4.4.3 and 5.0.2 using this plnkr and noticed they behave a bit different:

  • 4.4.3 both route transition and nested animation work ok
  • 5.0.2 no route transition but only nested animation works ok

matsko added a commit to matsko/angular that referenced this issue Oct 16, 2017

matsko added a commit to matsko/angular that referenced this issue Oct 16, 2017

matsko added a commit to matsko/angular that referenced this issue Oct 17, 2017

@tbosch tbosch closed this in 5a9ed2d Oct 18, 2017

matsko added a commit to matsko/angular that referenced this issue Nov 10, 2017

@matsko matsko reopened this Nov 10, 2017

matsko added a commit to matsko/angular that referenced this issue Nov 13, 2017

@jasonaden jasonaden closed this in d47b2a6 Nov 15, 2017

jasonaden added a commit that referenced this issue Nov 15, 2017

mhevery added a commit that referenced this issue Nov 18, 2017

matsko added a commit to matsko/angular that referenced this issue Nov 21, 2017

@matsko matsko reopened this Nov 21, 2017

@matsko

This comment has been minimized.

Show comment
Hide comment
@matsko

matsko Nov 21, 2017

Member

This guy will fix it for good: #20571

Member

matsko commented Nov 21, 2017

This guy will fix it for good: #20571

matsko added a commit to matsko/angular that referenced this issue Nov 21, 2017

@mhevery mhevery closed this in 0e012c9 Nov 22, 2017

wKoza added a commit to wKoza/angular that referenced this issue Dec 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment