Document compiler flag fullTemplateTypeCheck (at least in Release Notes)

[alan-agius4]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

In my html view I am referring a variable that it doesn't exist, This won't be catched unless someone consumes my library.

I am using NGC bin directly to compile my TS to NGC.

@Component({
	template: `<div *ngIf="isDisabled === true"></div>`
})
export class MainComponent  {

}

in the ngfactory.ts I can see that there is an error, however this is not emitted on compilation

const currVal_0:any = (_co.isDisabled === true);

Expected behavior

When compiling with NGC it should throw an error while compiling

Minimal reproduction of the problem with instructions

https://github.com/alan-agius4/angular-ngc-template-error

What is the motivation / use case for changing the behavior?

It should throw an error

Environment

Angular version: 4.4.4

For Tooling issues:

• Node version: 8.1.0
• Platform: Windows

Others:

[tbosch]

We have a new compiler setting called fullTemplateTypeCheck (see https://github.com/angular/angular/blob/master/packages/compiler-cli/src/transformers/api.ts#L99) which will reveal this error.

This setting will become the default in Angular 6, and is highly recommended. We didn't turn in on in Angular 5 to not break existing users. I.e. the behavior you are seeing here is exactly what users saw in Angular 4.

This works as intended, but somehow we forgot to document this. Keeping the bug open to track that we need to document this.

[tbosch]

Oh, there is a bug with fullTemplateTypeCheck right now, which will be fixed via #19582.

[alan-agius4]

The flag is only available in Angular 5 and later, or its also available in V4?

[tbosch]

Yes

…

On Fri, Oct 13, 2017 at 8:13 AM, Alan Agius ***@***.***> wrote: The flag is only available in Angular 5 or later? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#19681 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqKf-zxpsc2GXN8NVpUvNLgdMYBXODAks5sr34EgaJpZM4P2sTg> .

[tbosch]

We should first rollout fullTemplateTypeCheck in G3 before we document it though (see #19792).

[chuckjaz]

fullTemplateTypeCheck is not documented.

[mgol]

Why was this closed?

[devoto13]

@mgol It was documented some time ago: https://angular.io/guide/aot-compiler#fulltemplatetypecheck

[mgol]

Hmm, OK. I wonder why @chuckjaz wrote it's not documented just before closing then.

[kondi]

-t+w ;)

…

On Thu, Feb 8, 2018, 12:45 Michał Gołębiowski-Owczarek < ***@***.***> wrote: Hmm, OK. I wonder why @chuckjaz <https://github.com/chuckjaz> wrote it's not documented just before closing then. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#19681 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARAoAJplp0ejylVY93eOA2vdUQIHM-Tks5tSt5zgaJpZM4P2sTg> .

[chuckjaz]

Sorry. Yes. It is now documented. Sorry for the typo.

[kimamula]

This setting will become the default in Angular 6

Has this already been done?
The doc still says that this option is false by default and will default to true in the future.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}