Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: JSON Schema for @angular/service-worker #19847

Closed
lacolaco opened this Issue Oct 21, 2017 · 2 comments

Comments

4 participants
@lacolaco
Copy link
Contributor

lacolaco commented Oct 21, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

There isn't JSON schema file for ngsw.json.

Expected behavior

There is that and it should be used in testing of @angular/service-worker .

What is the motivation / use case for changing the behavior?

Angular CLI has a schema for .angular-cli.json and it is very useful to validate my JSON file. I think it will be better that ngsw.json has its own schema.

cc/ @alxhub

@gkalpak

This comment has been minimized.

Copy link
Member

gkalpak commented Dec 28, 2018

@cyrilletuzi

This comment has been minimized.

Copy link
Contributor

cyrilletuzi commented Dec 28, 2018

PR done in #27859

cyrilletuzi added a commit to cyrilletuzi/angular that referenced this issue Dec 29, 2018

cyrilletuzi added a commit to cyrilletuzi/angular that referenced this issue Dec 29, 2018

cyrilletuzi added a commit to cyrilletuzi/angular that referenced this issue Dec 29, 2018

cyrilletuzi added a commit to cyrilletuzi/angular that referenced this issue Dec 29, 2018

cyrilletuzi added a commit to cyrilletuzi/angular that referenced this issue Dec 30, 2018

cyrilletuzi added a commit to cyrilletuzi/angular that referenced this issue Dec 30, 2018

gkalpak added a commit to cyrilletuzi/angular that referenced this issue Jan 4, 2019

AndrewKushnir added a commit to cyrilletuzi/angular that referenced this issue Mar 5, 2019

gkalpak added a commit to cyrilletuzi/angular that referenced this issue Mar 5, 2019

gkalpak added a commit to cyrilletuzi/angular that referenced this issue Mar 5, 2019

Service Worker automation moved this from Backlog to Done Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.