New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if an unsupported future version of TypeScript is used #20669

Closed
chuckjaz opened this Issue Nov 28, 2017 · 2 comments

Comments

Projects
None yet
5 participants
@chuckjaz
Copy link
Member

chuckjaz commented Nov 28, 2017

I'm submitting a...


[x] Feature request

Current behavior

If you 2.5 or 2.6 with ngcversion 5.0.3 it will silently produce bad output in certain cases.

Expected behavior

It should warn that the user is using an unvalidated combination of ngc and TypeScript.

Consider emitting an error unless "disableTypeScriptVersionCheck" is true.

@spock123

This comment has been minimized.

Copy link

spock123 commented Nov 30, 2017

I second this - cost me 2 days until I realized it was TS 2.5.2 that was the culpit.

wKoza added a commit to wKoza/angular that referenced this issue Dec 2, 2017

Merge branch 'master' of https://github.com/angular/angular into angu…
…largh-20669

# Conflicts:
#	CHANGELOG.md
#	package.json
#	packages/compiler-cli/src/transformers/program.ts
#	packages/compiler-cli/test/ngc_spec.ts
@emilio-martinez

This comment has been minimized.

Copy link
Contributor

emilio-martinez commented Jan 2, 2018

I think this is pretty important and maybe the @angular/cli should follow this as well (cc @filipesilva) because there's such a high dependency on a typescript range.

For an example see angular/angular-cli#8434 (comment). This makes it so that typescript@next (2.7-ish) has a fix for something seemingly generated somewhere around Angular CLI 1.6.0 (meaning that downgrading CLI fixes issue), but Angular Compiler doesn't support TS beyond 2.5, and at the same time the 1.6.x CLI release is tied to Angular 5.1.x. Ultimately, it puts somewhat of a dependency block until TS 2.7 is supported in both Angular and the CLI for something that is seemingly created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment