fix(compiler-cli): do not lower expressions in non-modules #21649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
force-pushed
the
fix-xpression-lowering-for-non-modules
branch
from
a52662c
to
50bdce9
Compare
chuckjaz
added
target: patch
vicb
approved these changes
Jan 18, 2018
chuckjaz
force-pushed
the
fix-xpression-lowering-for-non-modules
branch
from
50bdce9
to
fef715b
Compare
chuckjaz
force-pushed
the
fix-xpression-lowering-for-non-modules
branch
from
fef715b
to
1ca292e
Compare
|
Create Issue and update PR to reference it. |
|
You can preview fef715b at https://pr21649-fef715b.ngbuilds.io/. |
|
You can preview 1ca292e at https://pr21649-1ca292e.ngbuilds.io/. |
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue: #21651
If a compilation contains a non-module
ngcmight convert it into a module if it contains a expression that might be rewritten.What is the new behavior?
Only modules are rewritten.
Does this PR introduce a breaking change?