Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language service is broken when used on Windows #21811

Closed
chuckjaz opened this issue Jan 26, 2018 · 2 comments
Closed

Language service is broken when used on Windows #21811

chuckjaz opened this issue Jan 26, 2018 · 2 comments
Labels
area: language-service Issues related to Angular's VS Code language service freq3: high regression Indicates than the issue relates to something that worked in a previous version type: bug/fix
Milestone
Backlog

Comments

@chuckjaz
Copy link
Contributor

I'm submitting a...


[x] Regression (a behavior that used to work and stopped working in a new release)

Current behavior

The 5.2.1 version of the language service does not work with TypeScript 2.6 on Windows.

Minimal reproduction of the problem with instructions

  1. On windows, install the 0.1.8 version of the language service.
  2. Open a project
  3. Try completion in an Angular template

Expected: completions, diagnostics, go-to-definition, etc.
Received: Nothing.
@chuckjaz chuckjaz added type: bug/fix freq3: high regression Indicates than the issue relates to something that worked in a previous version area: language-service Issues related to Angular's VS Code language service labels Jan 26, 2018
@ngbot ngbot bot modified the milestone: Backlog Jan 26, 2018
@chuckjaz chuckjaz mentioned this issue Jan 26, 2018
Closed
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jan 26, 2018
@chuckjaz
fix(language-service): ensure correct paths are passed to TypeScript
2338a88 
The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: angular#21811
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jan 26, 2018
@chuckjaz
fix(language-service): ensure correct paths are passed to TypeScript
a3e1059 
The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: angular#21811
@chuckjaz
Copy link
Contributor Author

Root cause of angular/vscode-ng-language-service#217

jasonaden pushed a commit that referenced this issue Jan 26, 2018
@chuckjaz @jasonaden
fix(language-service): ensure correct paths are passed to TypeScript (#…
250c8da 
…21812)

The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: #21811

PR Close #21812
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this issue Feb 23, 2018
@chuckjaz @jbogarthyde
fix(language-service): ensure correct paths are passed to TypeScript (a…
5d5fb54 
…ngular#21812)

The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: angular#21811

PR Close angular#21812
leo6104 pushed a commit to leo6104/angular that referenced this issue Mar 25, 2018
@chuckjaz @leo6104
fix(language-service): ensure correct paths are passed to TypeScript (a…
581edce 
…ngular#21812)

The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: angular#21811

PR Close angular#21812
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: language-service Issues related to Angular's VS Code language service freq3: high regression Indicates than the issue relates to something that worked in a previous version type: bug/fix
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@chuckjaz