New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng_package rule should fix up the main, etc. properties in package.json #22416

Closed
alexeagle opened this Issue Feb 23, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@alexeagle
Contributor

alexeagle commented Feb 23, 2018

There are a bunch of properties which should be set in the package.json of a distributed Angular library, including:
"main", "module", "es2015", "typings", and "metadata"

It would be easier for users to omit these fields, as it's hard to set them correctly.
ng_package should have a special attribute for a label pointing to package.json so it knows which input gets this special treatment.

/cc @juristr

@alexeagle alexeagle self-assigned this Feb 23, 2018

@ngbot ngbot bot added this to the needsTriage milestone Feb 26, 2018

alexeagle added a commit to alexeagle/angular that referenced this issue Feb 28, 2018

feat(bazel): ng_package adds package.json props
We now add the 'main', 'module', 'es2015', and 'typings' properties,
pointing to where the packaging tool lays them out.

Fixes angular#22416

alexeagle added a commit to alexeagle/angular that referenced this issue Feb 28, 2018

feat(bazel): ng_package adds package.json props
We now add the 'main', 'module', 'es2015', and 'typings' properties,
pointing to where the packaging tool lays them out.

Fixes angular#22416

alexeagle added a commit to alexeagle/angular that referenced this issue Feb 28, 2018

feat(bazel): ng_package adds package.json props
We now add the 'main', 'module', 'es2015', and 'typings' properties,
pointing to where the packaging tool lays them out.

Fixes angular#22416

@alexeagle alexeagle closed this in b6c9410 Feb 28, 2018

leo6104 added a commit to leo6104/angular that referenced this issue Mar 25, 2018

feat(bazel): ng_package adds package.json props (angular#22499)
We now add the 'main', 'module', 'es2015', and 'typings' properties,
pointing to where the packaging tool lays them out.

Fixes angular#22416

PR Close angular#22499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment