-
Notifications
You must be signed in to change notification settings - Fork 26.9k
build(bazel): fix bazel types reference directive resolves #25774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bazel): fix bazel types reference directive resolves #25774
Conversation
|
You can preview e90875a at https://pr25774-e90875a.ngbuilds.io/. |
|
You can preview 29a1d4d at https://pr25774-29a1d4d.ngbuilds.io/. |
|
You can preview 0ac89c3 at https://pr25774-0ac89c3.ngbuilds.io/. |
|
You can preview 1449f18 at https://pr25774-1449f18.ngbuilds.io/. |
|
You can preview a6ead09 at https://pr25774-a6ead09.ngbuilds.io/. |
|
You can preview 6b28523 at https://pr25774-6b28523.ngbuilds.io/. |
|
You can preview 00b403d at https://pr25774-00b403d.ngbuilds.io/. |
|
Changes from #25490 which was not merged into patch required and included here as well |
|
You can preview 285678f at https://pr25774-285678f.ngbuilds.io/. |
|
this pr has conflicts. can you please rebase? thanks |
|
@IgorMinar Looks like this got merged onto patch. |
|
You can preview 7ac00bc at https://pr25774-7ac00bc.ngbuilds.io/. |
|
you are right. all good then - the github ui has a lag and doesn't always auto-close merged PRs in a timely manner. |
|
|
||
| it('should have annotations rather than decorators', | ||
| () => { expect(shx.cat('fesm5/core.js')).not.toContain('__decorate'); }); | ||
| it('should have decorators', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops! We should not have done this on the patch branch.
/cc @IgorMinar @gkalpak
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6.1.x version of #25581