Skip to content

Conversation

@gregmagolan
Copy link
Contributor

6.1.x version of #25581

@gregmagolan gregmagolan added PR target: patch-only area: bazel Issues related to the published `@angular/bazel` build rules labels Aug 31, 2018
@mary-poppins
Copy link

You can preview e90875a at https://pr25774-e90875a.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 29a1d4d at https://pr25774-29a1d4d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 0ac89c3 at https://pr25774-0ac89c3.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1449f18 at https://pr25774-1449f18.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a6ead09 at https://pr25774-a6ead09.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6b28523 at https://pr25774-6b28523.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 00b403d at https://pr25774-00b403d.ngbuilds.io/.

@gregmagolan
Copy link
Contributor Author

gregmagolan commented Sep 4, 2018

Changes from #25490 which was not merged into patch required and included here as well

@mary-poppins
Copy link

You can preview 285678f at https://pr25774-285678f.ngbuilds.io/.

@gregmagolan gregmagolan added the action: merge The PR is ready for merge by the caretaker label Sep 6, 2018
IgorMinar pushed a commit that referenced this pull request Sep 6, 2018
@IgorMinar
Copy link
Contributor

this pr has conflicts. can you please rebase? thanks

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Sep 6, 2018
@gregmagolan
Copy link
Contributor Author

@IgorMinar Looks like this got merged onto patch.
b404d47
f85d3d7
e244b51

@gregmagolan gregmagolan closed this Sep 7, 2018
@mary-poppins
Copy link

You can preview 7ac00bc at https://pr25774-7ac00bc.ngbuilds.io/.

@IgorMinar
Copy link
Contributor

you are right. all good then - the github ui has a lag and doesn't always auto-close merged PRs in a timely manner.


it('should have annotations rather than decorators',
() => { expect(shx.cat('fesm5/core.js')).not.toContain('__decorate'); });
it('should have decorators',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! We should not have done this on the patch branch.
/cc @IgorMinar @gkalpak

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: bazel Issues related to the published `@angular/bazel` build rules cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants