Skip to content

Conversation

@mahalde
Copy link

@mahalde mahalde commented Nov 26, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The word behaviour is used in some of the documentation.

What is the new behavior?

Behaviour is changed to behavior.

Does this PR introduce a breaking change?

  • Yes
  • No

@brandonroberts brandonroberts self-assigned this Nov 26, 2018
@brandonroberts brandonroberts added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Nov 26, 2018
@ngbot ngbot bot added this to the Backlog milestone Nov 26, 2018
Copy link
Contributor

@jbogarthyde jbogarthyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 14, 2019
@brandonroberts brandonroberts removed the request for review from jenniferfell January 14, 2019 16:59
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 14, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: This is a docs only change and does not impact g3. Please run presubmit

@mahalde mahalde requested review from a team January 15, 2019 01:51
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 15, 2019
@AndrewKushnir
Copy link
Contributor

Presubmit

@AndrewKushnir
Copy link
Contributor

@brandonroberts I've rebased this PR on top of the latest master and run g3 presubmit to verify everything looks good. Could you please have a quick look at the changes to make sure there are no unexpected changes after rebase and return "merge" label back if everything is ok? Thank you.

@petebacondarwin
Copy link
Contributor

😭

@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Jan 22, 2019
@alxhub alxhub added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Jan 23, 2019
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 29, 2019
@jasonaden jasonaden closed this in 41e68f7 Jan 30, 2019
jasonaden pushed a commit that referenced this pull request Jan 30, 2019
@mahalde mahalde deleted the american-english-adjustment branch January 30, 2019 11:42
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants