New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

After a reorder animation states doesn't get detected correctly #28040

Open
zlepper opened this Issue Jan 10, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@zlepper
Copy link

zlepper commented Jan 10, 2019

馃悶 bug report

Affected Package

The issue is caused by package @angular/animations (I think)

Is this a regression?

Yes, the previous version in which this bug was not present was: 6 (at least)

Description

When a bunch of elements are rendered with ngFor and an animation trigger, the trigger doesn't update correctly when the array has changed. Only some elements gets into the new animation states.
Currently this is causing quite some problems for us, where some lists cannot be shown.

馃敩 Minimal Reproduction

https://stackblitz.com/edit/angular-animation-issue

Click the "toggle" button to expand the items (notice how all the items gets shown)
Click the "reorder" button (Notice how all items still are shown)
Click the "toggle" button again. (Notice items are gone)
Click the "reorder" button (Nothing visibly changes)
Click the "toggle" button (Only some items become visible.

If you change the animations to toggle between "display: none" and "display: ''", then the state changes happens as intended.

馃實 Your Environment

All environment details available on Stackblitz

Anything else relevant?
Seems to happen in all browsers

@matsko

This comment has been minimized.

Copy link
Member

matsko commented Jan 10, 2019

@zlepper which exact version of Angular was this working on in the past? I will do a bisect analysis.

@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment