Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce all application assets on ng build with Bazel schematics #28877

Closed
mgechev opened this Issue Feb 21, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@mgechev
Copy link
Member

mgechev commented Feb 21, 2019

馃殌 feature request

Relevant Package

@angular/bazel

Description

When the user runs ng build we should produce all the application assets so the application can be deployed to a static server.

Describe the solution you'd like

Consistency with the current behavior of the current CLI.

@mgechev mgechev added the comp: bazel label Feb 21, 2019

@ngbot ngbot bot added this to the needsTriage milestone Feb 21, 2019

@kyliau

This comment has been minimized.

Copy link
Member

kyliau commented Feb 27, 2019

Current behavior of ng build:

$ ng build
dist
鈹斺攢鈹 original
    鈹溾攢鈹 es2015-polyfills.js
    鈹溾攢鈹 es2015-polyfills.js.map
    鈹溾攢鈹 favicon.ico
    鈹溾攢鈹 index.html
    鈹溾攢鈹 main.js
    鈹溾攢鈹 main.js.map
    鈹溾攢鈹 polyfills.js
    鈹溾攢鈹 polyfills.js.map
    鈹溾攢鈹 runtime.js
    鈹溾攢鈹 runtime.js.map
    鈹溾攢鈹 styles.js
    鈹溾攢鈹 styles.js.map
    鈹溾攢鈹 vendor.js
    鈹斺攢鈹 vendor.js.map

1 directory, 14 files
$ ng build --prod
dist
鈹斺攢鈹 original
    鈹溾攢鈹 3rdpartylicenses.txt
    鈹溾攢鈹 es2015-polyfills.358ed1827c991dd2afb0.js
    鈹溾攢鈹 favicon.ico
    鈹溾攢鈹 index.html
    鈹溾攢鈹 main.9400166cffa4ab9df662.js
    鈹溾攢鈹 polyfills.407a467dedb63cfdd103.js
    鈹溾攢鈹 runtime.a5dd35324ddfd942bef1.js
    鈹斺攢鈹 styles.3ff695c00d717f2d2a11.css

1 directory, 8 files

@kyliau kyliau modified the milestones: needsTriage, Bazel 1.0 Feb 27, 2019

@mgechev

This comment has been minimized.

Copy link
Member Author

mgechev commented Feb 28, 2019

LGTM. original is the project name?

kyliau added a commit to kyliau/angular that referenced this issue Mar 6, 2019

fix(bazel): ng build should produce prod bundle
`ng build` should produce a bundle that could be readily deployed to
a web server, similar to the behavior of current `ng build` with
webpack.

Note that in Bazel, there is no `ng build` for dev bundles. Instead,
users are expected to run `ts_devserver`.

Closes angular#28877

@kyliau kyliau referenced this issue Mar 6, 2019

Closed

fix(bazel): ng build should produce prod bundle #29136

2 of 14 tasks complete

kyliau added a commit to kyliau/angular that referenced this issue Mar 6, 2019

fix(bazel): ng build should produce prod bundle
`ng build` should produce a bundle that could be readily deployed to
a web server, similar to the behavior of current `ng build` with
webpack.

Note that in Bazel, there is no `ng build` for dev bundles. Instead,
users are expected to run `ts_devserver`.

Closes angular#28877

@kara kara closed this in 14ce8a9 Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.