Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Pin browsers for schematics #28913

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Feb 22, 2019

Pin versions for Chrome, ChromeDriver, Firefox, and GeckoDriver.

https://github.com/bazelbuild/rules_typescript/blob/c09bc740230ce0fbf3ca92b6c8755da577ef1de2/internal/karma/browser_repositories.bzl

This is a temporary workaround until fix lands in web_testing.

This change requires Angular 8.0.0-beta.6 and above

PR closes #28724

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from a team as a code owner February 22, 2019 00:05
@kyliau kyliau added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Feb 22, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 22, 2019
@IgorMinar IgorMinar closed this in 1145bdb Feb 22, 2019
@kyliau kyliau deleted the browser_pinning branch March 22, 2019 22:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel schematics: Karma test broken on Mac OS
3 participants