Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteConfigLoadCancel, RouteConfigLoadError #29894

Open
edwardboyle opened this Issue Apr 14, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@edwardboyle
Copy link

edwardboyle commented Apr 14, 2019

馃殌 RouteConfigLoadCancel, RouteConfigLoadError

Description

We Like this:

 if (event instanceof RouteConfigLoadStart) {
  this.loadingRouteConfig = true;
  } else if (event instanceof RouteConfigLoadEnd) {
  this.loadingRouteConfig = false;
}

Many developers are making progress indicators based on this event with dozens of blog post based on using these events.

However, RouteConfigLoadEnd is not guaranteed to fire.

Describe the solution you'd like

RouteConfigLoadCancel RouteConfigLoadError

Alternative

export enum RouteConfigLoadEndState{
 Success,
 Cancel,
 Error
}
class RouteConfigLoadEnd{
  //...
  state: RouteConfigLoadEndState
}

@ngbot ngbot bot added this to the needsTriage milestone Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.