Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR in Cannot combine @Input decorators with query decorators #31977

Closed
ganySA opened this issue Aug 3, 2019 · 4 comments

Comments

@ganySA
Copy link

commented Aug 3, 2019

With Ivy : ERROR in Cannot combine @input decorators with query decorators when building.

Previously stated there would be line numbers and additional info i have tried to upgrade to Angular 9 Next, but it does not seem to show any line numbers.

First i found #31327, then to this fix #31123 but this does not seem to work as the latest Angular version does not print line numbers.

I have a large number of 3rd party libraries, and those libraries could in fact have more libraries so impossible to post a piece of code to reproduce other than tearing down half the application.

Angular CLI: 8.3.0-next.0
Node: 10.15.3
OS: win32 x64
Angular: 9.0.0-next.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker

Package Version

@angular-devkit/architect 0.803.0-next.0
@angular-devkit/build-angular 0.803.0-next.0
@angular-devkit/build-optimizer 0.803.0-next.0
@angular-devkit/build-webpack 0.803.0-next.0
@angular-devkit/core 8.3.0-next.0
@angular-devkit/schematics 8.3.0-next.0
@angular/cdk 8.1.1
@angular/cli 8.3.0-next.0
@angular/flex-layout 8.0.0-beta.26
@angular/material 8.1.2
@angular/pwa 0.803.0-next.0
@ngtools/webpack 8.3.0-next.0
@schematics/angular 8.3.0-next.0
@schematics/update 0.803.0-next.0
rxjs 6.5.2
typescript 3.5.3
webpack 4.38.0

@trotyl

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

This is a documented deprecated pattern, and the removal is designed to happen in Ivy.

@ngbot ngbot bot added this to the needsTriage milestone Aug 3, 2019

@JoostK

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Hello @ganySA,

This might be occurring when ngcc is processing the node_modules directory, in which case any FatalDiagnosticError is not currently handled properly. So that might explain why #31123 does not resolve the problem you have, as that fix was targeting ngtsc (the compiler used to compile from TypeScript source) and not ngcc (the compiler used to upgrade node_modules to ngtsc compatible code).

We have FW-1374 (internal only) to track work on this issue.

@ganySA

This comment has been minimized.

Copy link
Author

commented Aug 4, 2019

Great thanks - this looks correct.

@ganySA ganySA closed this Aug 4, 2019

JoostK added a commit to JoostK/angular that referenced this issue Aug 4, 2019
fix(ivy): ngcc - handle compilation diagnostics
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
JoostK added a commit to JoostK/angular that referenced this issue Aug 4, 2019
fix(ivy): ngcc - handle compilation diagnostics
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
JoostK added a commit to JoostK/angular that referenced this issue Aug 8, 2019
fix(ivy): ngcc - handle compilation diagnostics
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
JoostK added a commit to JoostK/angular that referenced this issue Aug 8, 2019
fix(ivy): ngcc - handle compilation diagnostics
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
JoostK added a commit to JoostK/angular that referenced this issue Aug 11, 2019
fix(ivy): ngcc - handle compilation diagnostics
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
JoostK added a commit to JoostK/angular that referenced this issue Aug 18, 2019
fix(ivy): ngcc - handle compilation diagnostics
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
JoostK added a commit to JoostK/angular that referenced this issue Aug 29, 2019
fix(ngcc): handle compilation diagnostics
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374
mhevery added a commit that referenced this issue Aug 29, 2019
fix(ngcc): handle compilation diagnostics (#31996)
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes #31977
Resolves FW-1374

PR Close #31996
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this issue Sep 6, 2019
fix(ngcc): handle compilation diagnostics (angular#31996)
Previously, any diagnostics reported during the compilation of an
entry-point would not be shown to the user, but either be ignored or
cause a hard crash in case of a `FatalDiagnosticError`. This is
unfortunate, as such error instances contain information on which code
was responsible for producing the error, whereas only its error message
would not. Therefore, it was quite hard to determine where the error
originates from.

This commit introduces behavior to deal with error diagnostics in a more
graceful way. Such diagnostics will still cause the compilation to fail,
however the error message now contains formatted diagnostics.

Closes angular#31977
Resolves FW-1374

PR Close angular#31996
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

commented Sep 15, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.