Skip to content

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in zone.js #33579

Closed
hansottowirtz opened this issue Nov 4, 2019 · 1 comment
Assignees
@JiaLiPassion
Labels
comp: zones
Milestone
needsTriage

Comments

@hansottowirtz
Copy link

@hansottowirtz hansottowirtz commented Nov 4, 2019

🐞 bug report

Affected Package

zone.js

Is this a regression?

No.

Description

I was inspecting some angular source code and noticed that vrdisplayconnected was misspelled in

angular/packages/zone.js/lib/browser/property-descriptor.ts

Line 147 in 5eb7426

'vrdisplyconnected',

This should become vrdisplayconnected.
JiaLiPassion added a commit to JiaLiPassion/angular that referenced this issue Nov 4, 2019
@JiaLiPassion
fix: fixes typo of zone.js patch vrdisplaydisconnected property
830f18b 
Close angular#33579
@JiaLiPassion JiaLiPassion mentioned this issue Nov 4, 2019
Closed
3 of 14 tasks complete
@JiaLiPassion JiaLiPassion self-assigned this Nov 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 4, 2019
@JiaLiPassion

This comment has been minimized.

Sign in to view
Copy link
Contributor

@JiaLiPassion JiaLiPassion commented Nov 4, 2019

Thanks, will fix it.
@alxhub alxhub closed this in 71b8e27 Nov 18, 2019
alxhub added a commit that referenced this issue Nov 18, 2019
@JiaLiPassion @alxhub
fix: fixes typo of zone.js patch vrdisplaydisconnected property (#33581)
1b7aa05 
Close #33579

PR Close #33581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaLiPassion JiaLiPassion

Labels
comp: zones
Projects
None yet
Milestone
  needsTriage
2 participants
@hansottowirtz @JiaLiPassion
You can’t perform that action at this time.