Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewContainerRef.createEmbeddedView append wrong location #33679

Closed
keatkeat87 opened this issue Nov 8, 2019 · 7 comments

Comments

@keatkeat87
Copy link

@keatkeat87 keatkeat87 commented Nov 8, 2019

https://github.com/keatkeat87/ng-container-issue

image

simple append a template to view container area

image

the location incorrect, if using template outlet, the location is correct.

ng-container-issue

angular 9.0.0 rc1

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 8, 2019

I believe that this is fixed in master via f63e5d9 and will be part of the next RC. Still, let's keep this open to add an integration test for this particular case as clearly our test coverage wasn't sufficient to catch this.

@IgorMinar IgorMinar modified the milestones: needsTriage, v9-blockers Nov 9, 2019
@IgorMinar

This comment has been minimized.

Copy link
Member

@IgorMinar IgorMinar commented Nov 9, 2019

we should test this with the latest builds or rc.2 once it's released.

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 12, 2019

Opened a PR #33755 to add a test for this particular case - a new test passes on master so we can assume that this issue is fixed now.

@kara kara closed this in 84a0105 Nov 12, 2019
kara added a commit that referenced this issue Nov 12, 2019
@keatkeat87

This comment has been minimized.

Copy link
Author

@keatkeat87 keatkeat87 commented Nov 14, 2019

@pkozlowski-opensource
I just update to 9.0.0 rc2, but look like this issue doesn't fix.
and look at kara test, she only test for the ngTemplateOutlet but not ViewContainerRef.createEmbeddedView().
I have update the repo to latest, you can clone it and test it again.

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 14, 2019

Thnx for coming back to me on this one @keatkeat87 - I can confirm that I can reproduce your exact use-case on master. Looking into it.

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 14, 2019

Thnx again @keatkeat87 for testing RC.2 - I can confirm now that the issue you are experiencing is a bug that wasn't covered by the existing tests! I've created a new PR with a test + fix: #33816

Thnx so much for helping us improving v9!

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 19, 2019

This just got fixed in master via 49c9f78 - will be part of the next RC release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.