Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale Regression: 150 locales purged #33681

Closed
doom777 opened this issue Nov 8, 2019 · 4 comments

Comments

@doom777
Copy link
Contributor

@doom777 doom777 commented Nov 8, 2019

馃悶 bug report

Affected Package

common

Is this a regression?

Yes, caused by #33634

Yes, the previous version in which this bug was not present was: ....

Description

Switiching to cldr-data pulled in a slim availableLocales file, which ends up bringing only 370 locales instead of 526.

A clear and concise description of the problem...

extract.js used to download locale data, and then load it into cldr-js. PR #33634 outsourced this work to an existing library cldr-data. Unfortunately, the availableLocales file in cldr-data does not have all the locales we had previously, about 1/4 of the locales are now not being generated.

馃敩 Minimal Reproduction

Delete packages/common/locales directory, and run yarn gulp cldr:extract
You will see only 374 locales. Testing will also fail, since some unit tests depend on the purged locales.

@doom777

This comment has been minimized.

Copy link
Contributor Author

@doom777 doom777 commented Nov 8, 2019

@petebacondarwin

This comment has been minimized.

Copy link
Member

@petebacondarwin petebacondarwin commented Nov 8, 2019

Ouch! Do we know if it is because the npm library does not contain those locales?

cc @josephperrott

@doom777

This comment has been minimized.

Copy link
Contributor Author

@doom777 doom777 commented Nov 8, 2019

Ok, I figured it out. It's the difference between modern and full. We can fix it, by adding a flag to our package.json

doom777 added a commit to doom777/angular that referenced this issue Nov 8, 2019
switching to cldr-data package resulted in
loss of some locales, since by default only core locales are loaded.
This PR adds a flag to tell cldr-data to use full locale coverage

fixes: angular#33681
@doom777 doom777 mentioned this issue Nov 8, 2019
3 of 12 tasks complete
@petebacondarwin

This comment has been minimized.

Copy link
Member

@petebacondarwin petebacondarwin commented Nov 8, 2019

Fixed by #33682 - thanks @doom777

@ngbot ngbot bot modified the milestone: needsTriage Nov 8, 2019
@IgorMinar IgorMinar modified the milestones: needsTriage, v9-blockers Nov 8, 2019
doom777 added a commit to doom777/angular that referenced this issue Nov 11, 2019
switching to cldr-data package resulted in
loss of some locales, since by default only core locales are loaded.
This PR adds a flag to tell cldr-data to use full locale coverage

fixes: angular#33681
@kara kara closed this in 472641c Nov 11, 2019
kara added a commit that referenced this issue Nov 11, 2019
switching to cldr-data package resulted in
loss of some locales, since by default only core locales are loaded.
This PR adds a flag to tell cldr-data to use full locale coverage

fixes: #33681

PR Close #33682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.