Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular/core dependency not found in package.json when ng add @angular/bazel #34164

Closed
splincode opened this issue Nov 30, 2019 · 1 comment
Closed

Comments

@splincode
Copy link
Contributor

@splincode splincode commented Nov 30, 2019

馃悶 bug report

Affected Package

The issue is caused by package @angular/bazel

Description

Optional @angular/core package may be in dependency section in package.json but installed in project

馃敩 Minimal Reproduction

$ git clone https://github.com/ngxs/store.git
$ yarn install
$ ng add @angular/bazel

馃敟 Exception or Error

@angular/core dependency not found in package.json

馃實 Your Environment

Angular Version:
latest

@ngbot ngbot bot added this to the needsTriage milestone Dec 2, 2019
@alan-agius4 alan-agius4 self-assigned this Dec 2, 2019
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Dec 2, 2019
With this change we fix the logic to detect if a package is installed, removing a package and add a package by using the CLI helpers.

Closes angular#34164
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Dec 2, 2019
With this change we fix the logic to detect if a package is installed, removing a package and add a package by using the CLI helpers.

Closes angular#34164
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Dec 2, 2019
鈥l @angular/bazel

With this change we fix the logic to detect if a package is installed, removing a package and add a package by using the CLI schematic helpers.

Also we save `@angular/bazel` package directly as a `devDependency` when doing `ng-add`.

Closes angular#34164
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 2, 2019
mhevery added a commit that referenced this issue Dec 2, 2019
鈥l @angular/bazel (#34181)

With this change we fix the logic to detect if a package is installed, removing a package and add a package by using the CLI schematic helpers.

Also we save `@angular/bazel` package directly as a `devDependency` when doing `ng-add`.

Closes #34164

PR Close #34181
@mhevery mhevery closed this in 0cd8431 Dec 2, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jan 2, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.