Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update @angular/platform-server dependency xhr2 to 0.2.0 #36358

Closed
aresn opened this issue Mar 31, 2020 · 2 comments
Closed

update @angular/platform-server dependency xhr2 to 0.2.0 #36358

aresn opened this issue Mar 31, 2020 · 2 comments
Assignees
@alan-agius4
Labels
area: server Issues related to server-side rendering
Milestone
needsTriage

Comments

@aresn
Copy link

aresn commented Mar 31, 2020

@angular/platform-server is still depending on "xhr2": "^0.1.4". This version of xhr2 is using the depreciated "new Buffer()". Please update this dependency to "0.2.0". The only difference between these two versions is the use of "Buffer.from()" instead of "new Buffer()"
@alxhub alxhub added the area: server Issues related to server-side rendering label Mar 31, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 31, 2020
@hiepxanh
Copy link
Contributor

hiepxanh commented Apr 1, 2020

Hope it will be update soon

@alan-agius4 alan-agius4 self-assigned this Apr 1, 2020
@alan-agius4 alan-agius4 mentioned this issue Apr 1, 2020
Closed
@alxhub alxhub closed this as completed in b59bc0e Apr 1, 2020
alxhub pushed a commit that referenced this issue Apr 1, 2020
@alan-agius4 @alxhub
fix(platform-server): update xhr2 dependency (#36366)
14ae3c0 
Previous versions of xhr2 used the depreciated "new Buffer()".

Closes #36358

PR Close #36366
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alan-agius4 alan-agius4

Labels
area: server Issues related to server-side rendering
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(platform-server): update xhr2 dependency
4 participants
@aresn @alxhub @hiepxanh @alan-agius4