fix(http): change http interfaces to types #4024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbcross
added
type: bug/fix
comp: data-access
action: review
IgorMinar
added
pr_state: LGTM
action: merge
|
Merging PR #4024 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4024. |
1 similar comment
|
Merging PR #4024 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4024. |
|
Merging PR #4024 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-4024. |
mary-poppins
removed
the
action: merge
Types were previously not handled correctly by the type definition generation process, so a couple of things in http had to be changed to interfaces. This issue has been fixed, so now they're types again.
jeffbcross
force-pushed
the
http-types
branch
from
4423a96
to
58dea64
Compare
robwormald
pushed a commit
to robwormald/angular
that referenced
this pull request
Sep 25, 2015
Types were previously not handled correctly by the type definition generation process, so a couple of things in http had to be changed to interfaces. This issue has been fixed, so now they're types again. Closes angular#4024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types were previously not handled correctly by the type definition
generation process, so a couple of things in http had to be changed
to interfaces. This issue has been fixed, so now they're types again.