New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Location): move out of router package and into platform/common #4943

Closed
NathanWalker opened this Issue Oct 27, 2015 · 8 comments

Comments

Projects
None yet
4 participants
@NathanWalker
Contributor

NathanWalker commented Oct 27, 2015

Summary

Discussion here #4905 has brought to light that it would be beneficial for Location to exist on it's own and not dependent on the router bundle.

Problem

Users will need to access url query params whether they are using the component router or not.
Sample user story:

Manager needs a quick form posted on an isolated marketing page that is all on a single page with no routes.
Developer wants to build the form using Angular2 and plans to process various flows via url query params used across several different links that are emailed via a marketing campaign.
Developer only wants to use the core bundle as there will be no routes on this page and needs to access the query params easily for various usability/marketing tracking purposes.

Proposal

Make Location a part of core. Or any other module that would be included with the main bundle. Thoughts? I can begin working on this in next day.

/cc @mhevery @btford

@btford

This comment has been minimized.

Contributor

btford commented Oct 27, 2015

I think this is good, but hold off before implementing anything, there are a few major refactors we need to wrap up.

This is the only reason I was hesitant in the other thread– it's not yet pragmatic to make this change until #3563 lands. @matsko and I will pair on that next week, and then if you're eager to help, I'd be happy to guide you through helping out with this.

Thanks!

@NathanWalker

This comment has been minimized.

Contributor

NathanWalker commented Oct 27, 2015

Sounds good @btford I'd love to help, lemme know. If anything else comes up in the community-help realm that is falling behind and no one else can get to it, feel free to assign me anything in meantime to assist further.

I'm starting to feel like it's hard to grab just anything from community-help due to what I just ran into with #4824

@btford

This comment has been minimized.

Contributor

btford commented Oct 29, 2015

@NathanWalker please don't be discouraged. The problem with #4824 was that Misko tagged it without knowing much about the context. It was a mistake on our part.

Once we have the right organization, we'll definitely need something like #4824 for using a location service without the router.

@NathanWalker

This comment has been minimized.

Contributor

NathanWalker commented Mar 17, 2016

@btford Following up on some things and last thing I wanted to also ping you about here. If things are close to handling this refactor, I'd be interested in tackling this over next 2-3 weeks.

@norbertsienkiewicz

This comment has been minimized.

norbertsienkiewicz commented Apr 5, 2016

Location as a core sounds great 👍

@NathanWalker NathanWalker changed the title from refactor(Location): move out of router package and onto its own to refactor(Location): move out of router package and into core Apr 5, 2016

@mhevery

This comment has been minimized.

Member

mhevery commented Apr 8, 2016

@NathanWalker A PR would be most welcome!

@NathanWalker

This comment has been minimized.

Contributor

NathanWalker commented Apr 8, 2016

I'll start a branch on the refactor tomorrow. Thanks @mhevery.

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 8, 2016

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 8, 2016

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 8, 2016

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 8, 2016

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 8, 2016

@NathanWalker

This comment has been minimized.

Contributor

NathanWalker commented Apr 8, 2016

@mhevery 2 Refactor options exist here now:
#7962

@NathanWalker NathanWalker changed the title from refactor(Location): move out of router package and into core to refactor(Location): move out of router package and into core (or common) Apr 8, 2016

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 9, 2016

@NathanWalker NathanWalker changed the title from refactor(Location): move out of router package and into core (or common) to refactor(Location): move out of router package and into platform/browser Apr 10, 2016

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 10, 2016

refactor(Location): out of router and into platform/browser
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/browser`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/browser’;
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 10, 2016

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 10, 2016

refactor(Location): out of router and into platform/browser
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/browser`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/browser’;
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 10, 2016

refactor(Location): out of router and into platform/browser
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/browser`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/browser’;
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 10, 2016

refactor(Location): out of router and into platform/browser
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/browser`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/browser’;
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/browser
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/browser`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/browser’;
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/browser
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/browser`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/browser’;
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/browser
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/browser`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/browser’;
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/common`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/common`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/common`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` has been moved out of `router` and into `platform/common`.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 11, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 12, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 13, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 14, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

NathanWalker added a commit to NathanWalker/angular that referenced this issue Apr 15, 2016

refactor(Location): out of router and into platform/common
closes angular#4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

robertmesserle added a commit that referenced this issue Apr 19, 2016

refactor(Location): out of router and into platform/common
closes #4943

BREAKING CHANGE:

`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.

Before:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/router';

import {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';
```

After:

```
import {
  PlatformLocation,
  Location,
  LocationStrategy,
  HashLocationStrategy,
  PathLocationStrategy,
  APP_BASE_HREF}
from 'angular2/platform/common';

import {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';
```

@mhevery mhevery closed this in b602bd8 Apr 20, 2016

@NathanWalker NathanWalker changed the title from refactor(Location): move out of router package and into platform/browser to refactor(Location): move out of router package and into platform/common Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment