-
Notifications
You must be signed in to change notification settings - Fork 26.9k
Backport NgOptimizedImage to v13 #49486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There seem to be legitimate failures. Please ping if this is ready for review. Converting to draft in the meanwhile. |
0770404 to
60d8ccf
Compare
01fbf9a to
1dcacaf
Compare
AndrewKushnir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atcastle looks great, just left a few minor comments.
packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
Outdated
Show resolved
Hide resolved
AndrewKushnir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
kara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one typo
Backport the image optimization features from verion 15 to version 13
|
@devversion this PR is ready for merge, but we didn't add the "merge" label, so that it didn't show up in the Caretaker queue. The Pullapprove also wants an LGTM from you, could you please have a quick look at the DevInfra-related changes? I think we can skip DevRel's review as we are copy'n'pasting docs from the previous backport and an overall plan was LGTM'ed previously by DevRel. |
josephperrott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
josephperrott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: global-approvers
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR is an extension of the work done in #49278. This extend the backport of NgOptimizedImage from version 14 to version 13.
To aid in review, here's a list of additional changes made, beyond those made in the version 14 backport:
ng_optimized_image.ts:hostproperty from @directive, because this does not behave the same pre-14.this.renderer.setStylepreconnect_link_checker.ts:optionalparam ininjectconfig is different pre-14preload-link-creator.ts:All built-in loader files (Imgix, Cloudflare, etc):
Testing
render3.ts:withHead, andwrapTestng_optimized_image_spec.ts:image_loader_spec.ts:e2e tests:
Docs
References to using NgOptimizedImage in standalone removed.
Note that there may be e2e failures in this PR initially, as I'm unable to run the pre-Angular15 e2e tests locally.
CC: @AndrewKushnir @pkozlowski-opensource @kara