Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer dependency on reflect metadata pinned to 0.1.2 ? #6415

Closed
johnpapa opened this issue Jan 12, 2016 · 4 comments
Closed

peer dependency on reflect metadata pinned to 0.1.2 ? #6415

johnpapa opened this issue Jan 12, 2016 · 4 comments

Comments

@johnpapa
Copy link
Contributor

when i npm install i get a peer dependency issue on reflect metadata. why? cuz we had "reflect-metadata": "^0.1.2", and 0.1.3 is out. But Angular requires 0.1.2. for now i told the samples to use 0.1.2 exactly … but if this is right, we need to fix this a better way.

Ng has a peer dep on 1.2. Anyone installing angular 2 directly will hit this then. Unless they go type in a specific version.

I think it happens under this case ... Your package json already has ^0.1.2 and then you run npm install.

reply from @IgorMinar ...
I guess we could change our package.json to contain version range for metadata and other peerDeps
e.g. 0.1.x rather than 0.1.2
you will still have issues once reflect-metadata goes to 0.2, but that will likely contain breaking changes
so we need to control the upgrade when that happens
can you file an issue and cc me on it please?

@digitaldonkey
Copy link


npm install
npm WARN angular2@2.0.0-beta.5 requires a peer of reflect-metadata@0.1.2 but none was installed.

As far as i can see there is no release for reflect-metadata tagged with 1.2 https://github.com/rbuckton/ReflectDecorators/releases

How is this possible?

@clemgrim
Copy link

clemgrim commented Apr 9, 2016

+1, same issue with rxjs

It should be better to use "reflect-metadata": "^0.1.2" ?

@pkozlowski-opensource
Copy link
Member

It is not pinned any more, currently "reflect-metadata": "^0.1.3", see:

"reflect-metadata": "^0.1.3",

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants