New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peer dependency on reflect metadata pinned to 0.1.2 ? #6415
Comments
As far as i can see there is no release for reflect-metadata tagged with 1.2 https://github.com/rbuckton/ReflectDecorators/releases How is this possible? |
+1, same issue with rxjs It should be better to use |
It is not pinned any more, currently Line 22 in a19c4e8
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
when i
npm install
i get a peer dependency issue on reflect metadata. why? cuz we had"reflect-metadata": "^0.1.2",
and0.1.3
is out. But Angular requires0.1.2
. for now i told the samples to use0.1.2
exactly … but if this is right, we need to fix this a better way.Ng has a peer dep on 1.2. Anyone installing angular 2 directly will hit this then. Unless they go type in a specific version.
I think it happens under this case ... Your package json already has ^0.1.2 and then you run npm install.
reply from @IgorMinar ...
I guess we could change our package.json to contain version range for metadata and other peerDeps
e.g. 0.1.x rather than 0.1.2
you will still have issues once reflect-metadata goes to 0.2, but that will likely contain breaking changes
so we need to control the upgrade when that happens
can you file an issue and cc me on it please?
The text was updated successfully, but these errors were encountered: