Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named optional parameters in @Injectable ctors #7344

Closed
kegluneq opened this issue Feb 29, 2016 · 4 comments
Closed

Support named optional parameters in @Injectable ctors #7344

kegluneq opened this issue Feb 29, 2016 · 4 comments

Comments

@kegluneq
Copy link
Contributor

@kegluneq kegluneq commented Feb 29, 2016

Right now, named optional parameters do not work in @Injectable ctors, but maybe they should.

  • Should a named optional parameter be implicitly annotated as @Optional?
@langley-agm
Copy link

@langley-agm langley-agm commented Mar 6, 2016

+1, I agree, es6/Typescript already handle optional parameters why add a new annotation to do something similar yet not as good and that breaks the existing functionality? I wonder why is it breaking , does Angular DI call the constructor with a null instead of not providing a value at all?

@vicb vicb added the flag: dart label Aug 5, 2016
@vicb vicb closed this Aug 5, 2016
@langley-agm
Copy link

@langley-agm langley-agm commented Aug 25, 2016

Is there any reason for closing this?

@zoechi
Copy link
Contributor

@zoechi zoechi commented Sep 10, 2016

@langley-agm because Dart issues are now maintained in dart-lang/angular2

@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.