New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make INTERPOLATE_REGEXP customizable #7417 #8865

Closed
vicb opened this Issue May 26, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@vicb
Contributor

vicb commented May 26, 2016

INTERPOLATE_REGEXP was made configurable in #7417

I'm not sure if this will work well with i18n

/cc @laco0416

@mhevery

This comment has been minimized.

Member

mhevery commented May 26, 2016

A better design would be to pass in start/end delimiter rather than a generic RegExp.

@lacolaco

This comment has been minimized.

Contributor

lacolaco commented May 27, 2016

I agreed. I think CompilerConfig#interpolateSymbols is better
2016/05/27 5:43 "Miško Hevery" notifications@github.com:

A better design would be to pass in start/end delimiter rather than a
generic RegExp.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8865 (comment)

@lacolaco

This comment has been minimized.

Contributor

lacolaco commented May 27, 2016

Do we need the following symbol settings?

  • interpolationStart/End
  • i18nStart/End
    2016/05/27 9:13 "Suguru Inatomi" laco0416@gmail.com:

I agreed. I think CompilerConfig#interpolateSymbols is better
2016/05/27 5:43 "Miško Hevery" notifications@github.com:

A better design would be to pass in start/end delimiter rather than a
generic RegExp.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8865 (comment)

@pkozlowski-opensource

This comment has been minimized.

Member

pkozlowski-opensource commented Jun 10, 2016

This got fixed in master via c3fafa0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment