Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] {messages.length, plural, ...} should not be expanded to a list #9072

Closed
vicb opened this Issue Jun 7, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@vicb
Copy link
Contributor

vicb commented Jun 7, 2016

From expander.ts

 * { messages.length, plural,
 *   =0 {zero}
 *   =1 {one}
 *   =other {more than one}
 * }
 *
 * will be expanded into
 *
 * <ul [ngPlural]="messages.length">
 *   <template [ngPluralCase]="0"><li i18n="plural_0">zero</li></template>
 *   <template [ngPluralCase]="1"><li i18n="plural_1">one</li></template>
 *   <template [ngPluralCase]="other"><li i18n="plural_other">more than one</li></template>
 * </ul>

The plural should be expanded to a text node and not add element nodes

@vicb vicb added the type: bug/fix label Jun 7, 2016

@vicb vicb self-assigned this Jun 7, 2016

@vicb vicb added the comp: i18n label Jun 7, 2016

@vicb vicb referenced this issue Jun 8, 2016

Closed

[i18n] future 2.x plan #9104

13 of 21 tasks complete

vicb added a commit to vicb/angular that referenced this issue Jun 16, 2016

vicb added a commit to vicb/angular that referenced this issue Jun 17, 2016

vicb added a commit to vicb/angular that referenced this issue Jun 17, 2016

@vicb vicb closed this in 721f53f Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.