New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate obsolete PLATFORM_DIRECTIVES and PLATFORM_PIPES #9320

Closed
IgorMinar opened this Issue Jun 17, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@IgorMinar
Member

IgorMinar commented Jun 17, 2016

While investigating #9303 we realized that we accidentally left behind PLATFORM_DIRECTIVES and PLATFORM_PIPES tokes in spite of documenting them as being removed in the changelog.

Now that the the platform directives and pipes are configured via the CompilerConfig we should deprecate these tokens and remove them in the future.

@pkozlowski-opensource

This comment has been minimized.

Member

pkozlowski-opensource commented Jun 19, 2016

Hmm, if I read #9319 correctly we will still need those symbols

@IgorMinar

This comment has been minimized.

Member

IgorMinar commented Jun 20, 2016

I think that's a typo in 9319. see
#9319 (comment)

On Sat, Jun 18, 2016 at 11:26 PM Pawel Kozlowski notifications@github.com
wrote:

Hmm, if I read #9319 #9319
correctly we will still need those symbols


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9320 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AANM6IAUpwpQVE5vgU3znC7TKfv6aj65ks5qNOEygaJpZM4I4wYU
.

@IgorMinar

This comment has been minimized.

Member

IgorMinar commented Jun 23, 2016

@tbosch can you clarify?

@tbosch

This comment has been minimized.

Member

tbosch commented Jun 23, 2016

Yes, that is a typo in #9319 (I added a comment there).
Yes, let's remove these two tokens.

@tbosch tbosch modified the milestones: 2.0.0-rc.5, 2.0.0-rc.4 Jun 27, 2016

@tbosch

This comment has been minimized.

Member

tbosch commented Jul 7, 2016

Platform directives / Platform pipes are now being configured via app modules. I.e. these tokens should be deprecated and then removed.

@IgorMinar

This comment has been minimized.

Member

IgorMinar commented Aug 9, 2016

this was done in rc5

@IgorMinar IgorMinar closed this Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment