Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(validations): add support to bind dir validators #11116
This PR builds on @tolemac's original PR to finish adding support for dir validators. He's done most of the work here; just putting on finishing touches.
Summary: Previously, it wasn't possible to bind to validators like
<input name="first" ngModel [required]="isRequired">
...regardless of the value of
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.
referenced this pull request
Aug 27, 2016
We're doing it this way because we don't it to be a breaking change? I find it a bit weird to have three properties instead of two.
Cause we could have had two properties