feat(forms): add ng-pending CSS class during async validation #11243

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Projects
None yet
8 participants
@pkozlowski-opensource

@kara as discussed yesterday trying to help with the forms. Here is my stab at the easy stuff to dive into the code.

Closes #10336

@googlebot googlebot added the cla: yes label Sep 1, 2016

@@ -37,6 +37,9 @@ export class AbstractControlStatus {
get ngClassInvalid(): boolean {
return isPresent(this._cd.control) ? this._cd.control.invalid : false;
}
+ get ngClassPending(): boolean {
+ return isPresent(this._cd.control) ? this._cd.control.pending : false;

This comment has been minimized.

@vicb

vicb Sep 1, 2016

Member

remove isPresent pls. (yes others too).

@vicb

vicb Sep 1, 2016

Member

remove isPresent pls. (yes others too).

This comment has been minimized.

@vicb vicb added the comp: forms label Sep 1, 2016

@vicb vicb added this to the 2.0.1 milestone Sep 1, 2016

@vicb

This comment has been minimized.

Show comment
Hide comment
@vicb

vicb Sep 1, 2016

Member

@kara could you please review ?

Member

vicb commented Sep 1, 2016

@kara could you please review ?

@kara

This comment has been minimized.

Show comment
Hide comment
@kara

kara Sep 1, 2016

Contributor

LGTM, thanks @pkozlowski-opensource

Contributor

kara commented Sep 1, 2016

LGTM, thanks @pkozlowski-opensource

@mprobst

This comment has been minimized.

Show comment
Hide comment
@mprobst

mprobst Sep 2, 2016

Contributor

@IgorMinar can you confirm that this is good to merge?

Contributor

mprobst commented Sep 2, 2016

@IgorMinar can you confirm that this is good to merge?

@vicb

This comment has been minimized.

Show comment
Hide comment
@vicb

vicb Sep 2, 2016

Member

@mprobst milestone 2.0.1 => later

Member

vicb commented Sep 2, 2016

@mprobst milestone 2.0.1 => later

@IgorMinar

This comment has been minimized.

Show comment
Hide comment
@IgorMinar

IgorMinar Sep 2, 2016

Member

we are in feature freeze. we should delay merging this until we branch off a bugfix branch for 2.0/

Member

IgorMinar commented Sep 2, 2016

we are in feature freeze. we should delay merging this until we branch off a bugfix branch for 2.0/

@vicb vicb modified the milestones: 2.0.1, 2.0.2 Sep 29, 2016

@vsavkin vsavkin added the comp: forms label Oct 4, 2016

@vicb

This comment has been minimized.

Show comment
Hide comment
@vicb

vicb Oct 11, 2016

Member

Could you please rebase the PR

Member

vicb commented Oct 11, 2016

Could you please rebase the PR

@pkozlowski-opensource

This comment has been minimized.

Show comment
Hide comment
@pkozlowski-opensource

pkozlowski-opensource Oct 11, 2016

Member

@vicb rebased, all back to green.

@vicb rebased, all back to green.

@alxhub alxhub merged commit 97bc971 into angular:master Oct 19, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

btrigueiro added a commit to btrigueiro/angular that referenced this pull request Oct 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment