Add a new directive lifecycle hook #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var CONTEXT_ACCESSOR = "this.context"; | ||
| var CHANGE_LOCAL = "change"; | ||
| var CHANGES_LOCAL = "changes"; | ||
| var LOCALS_ACCESSOR = "this.locals"; | ||
| var TEMP_LOCAL = "temp"; | ||
|
|
||
| function typeTemplate(type:string, cons:string, detectChanges:string, setContext:string):string { | ||
| function typeTemplate(type:string, cons:string, detectChanges:string, |
There was a problem hiding this comment.
It's not immediately clear what this function does. Could you add a function description? Also not obvious what cons is.
vsavkin
force-pushed
the
change_detection_after_children_callback
branch
from
e71c00f
to
e92918b
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #995
@tbosch, this PR touches ProtoView