Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): clear errors on disable #11463

Merged
merged 1 commit into from Sep 9, 2016

Conversation

Projects
None yet
4 participants
@kara
Copy link
Contributor

kara commented Sep 8, 2016

No description provided.

@googlebot googlebot added the cla: yes label Sep 8, 2016

@kara kara force-pushed the kara:errors branch from 2722dbc to 1086343 Sep 9, 2016

@kara kara added the PR state: WIP label Sep 9, 2016

@kara kara force-pushed the kara:errors branch from 1086343 to fdd790a Sep 9, 2016

@kara kara removed the PR state: WIP label Sep 9, 2016

@kara kara force-pushed the kara:errors branch from fdd790a to 549ebcb Sep 9, 2016

@@ -232,17 +233,16 @@ export abstract class AbstractControl {
onlySelf = normalizeBool(onlySelf);
emitEvent = isPresent(emitEvent) ? emitEvent : true;

this._setInitialStatus();

This comment has been minimized.

Copy link
@vsavkin

vsavkin Sep 9, 2016

Contributor

Why do you need to reset the initial status on every update?

This comment has been minimized.

Copy link
@kara

kara Sep 9, 2016

Author Contributor

Let's talk in person


if (this._disabledChanged(originalStatus)) {
this._updateValue();
if (this._status == VALID || this._status == PENDING) {

This comment has been minimized.

Copy link
@vsavkin

vsavkin Sep 9, 2016

Contributor

===

@kara kara force-pushed the kara:errors branch from 549ebcb to 1732863 Sep 9, 2016

@evmar evmar merged commit 673de00 into angular:master Sep 9, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kara kara added the comp: forms label Sep 13, 2016

@kara kara deleted the kara:errors branch Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.