fix(upgrade): allow attribute selectors for components in ng2 which a… #11808

Merged
merged 1 commit into from Sep 23, 2016

Conversation

Projects
None yet
4 participants
@mhevery
Member

mhevery commented Sep 21, 2016

Fixes #11280

@googlebot googlebot added the cla: yes label Sep 21, 2016

@IgorMinar

lgtm

just for reference this only solves the issue marked as 2/ in this comment: #11280 (comment)

@IgorMinar

This comment has been minimized.

Show comment
Hide comment
@IgorMinar

IgorMinar Sep 21, 2016

Member

ci fails, please fix

Member

IgorMinar commented Sep 21, 2016

ci fails, please fix

@mhevery

This comment has been minimized.

Show comment
Hide comment
@mhevery

mhevery Sep 22, 2016

Member

Per our discussion we are not solving issue 1/

Member

mhevery commented Sep 22, 2016

Per our discussion we are not solving issue 1/

@rkirov rkirov merged commit 6fc4652 into angular:master Sep 23, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

IgorMinar added a commit that referenced this pull request Sep 23, 2016

@mhevery mhevery deleted the mhevery:issue-11280 branch Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment