Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(forms): Added emitEvent to AbstractControl methods #11949
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
@vicb #11948 (comment) thanks for the info, i haven't see the information about logical separating commits, in https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit . But yea you are right, it makes it much easier to read. Fixed it.
@kara sry for the 1. question, it was miss written i mean: (im very sorry about that "angry" comment)
I'm at angular days in germany right now and confused a little bit.
Thanks for doing the tests! The FormArray and FormGroup tests need some updates, then we should be good to go.