fix(compiler): walk third party modules #12453

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
4 participants
@vicb
Member

vicb commented Oct 22, 2016

fixes #11889
fixes #12428

Todo:

  • fix one failing test,
  • add more tests (inline todos)

@googlebot googlebot added the cla: yes label Oct 22, 2016

@vicb vicb changed the title from [WIP] fix(compiler): walk third party modules to fix(compiler): walk third party modules Oct 24, 2016

@@ -7,7 +7,9 @@
*/
import {platformBrowser} from '@angular/platform-browser';
+
+import {MainModuleNgFactory} from '../src/module.ngfactory';

This comment has been minimized.

@tbosch

tbosch Oct 24, 2016

Member

revert

@tbosch

tbosch Oct 24, 2016

Member

revert

+ expect(thirdPComps[1].children[0].children[0].data).toEqual('other-3rdP-component');
+ });
+
+ // https://github.com/angular/angular/pull/12399

This comment has been minimized.

@tbosch

tbosch Oct 24, 2016

Member

Wrong link

@tbosch

tbosch Oct 24, 2016

Member

Wrong link

+This folder emulates consuming precompiled modules and components.
+It is compiled separately from the other sources under `src`
+to only generate `*.js` / `*.d.ts` / `*.metadata.json` files,
+but no `*.ngfactory.ts` files.

This comment has been minimized.

@tbosch

tbosch Oct 24, 2016

Member

Add a sentence: Do not import components/directives from here directly as we want to test that ngc still compiles them.

@tbosch

tbosch Oct 24, 2016

Member

Add a sentence: Do not import components/directives from here directly as we want to test that ngc still compiles them.

@@ -250,6 +250,12 @@ export class ReflectorHost implements StaticReflectorHost, ImportGenerator {
} else {
const sf = this.program.getSourceFile(filePath);
if (!sf) {
+ if (this.context.fileExists(filePath)) {

This comment has been minimized.

@tbosch

tbosch Oct 24, 2016

Member

Add a unit test to reflector_host_spec.ts

@tbosch

tbosch Oct 24, 2016

Member

Add a unit test to reflector_host_spec.ts

@vicb

This comment has been minimized.

Show comment
Hide comment
@vicb

vicb Oct 24, 2016

Member

Thanks @tbosch and @chuckjaz for your help.

Comments have been addressed in the latest version (created an issue for the reflector tests).

@IgorMinar should be ready to be merged now

Member

vicb commented Oct 24, 2016

Thanks @tbosch and @chuckjaz for your help.

Comments have been addressed in the latest version (created an issue for the reflector tests).

@IgorMinar should be ready to be merged now

@IgorMinar IgorMinar merged commit a838aba into angular:master Oct 24, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vsavkin added a commit to vsavkin/angular that referenced this pull request Oct 25, 2016

IgorMinar added a commit that referenced this pull request Oct 27, 2016

@vicb vicb deleted the vicb:1021-aot branch Nov 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment