Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 2.1 #13294

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
@alexeagle
Copy link
Contributor

commented Dec 7, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@googlebot googlebot added the cla: yes label Dec 7, 2016

@alexeagle alexeagle requested a review from chuckjaz Dec 7, 2016

@alexeagle

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2016

Note, this is currently blocked on a TS 2.1-compatible tsickle.
/cc @evmar

@chuckjaz

This comment has been minimized.

Copy link
Member

commented Dec 8, 2016

The changes to TypeScript broke ts_plugin.ts. Feel free to remove it and the corresponding tests as it is currently not used.

@chuckjaz
Copy link
Member

left a comment

Fix or remove ts_plugin.ts

@@ -12,6 +12,14 @@ import {Evaluator, errorSymbol, isPrimitive} from './evaluator';
import {ClassMetadata, ConstructorMetadata, FunctionMetadata, MemberMetadata, MetadataEntry, MetadataError, MetadataMap, MetadataObject, MetadataSymbolicBinaryExpression, MetadataSymbolicCallExpression, MetadataSymbolicExpression, MetadataSymbolicIfExpression, MetadataSymbolicIndexExpression, MetadataSymbolicPrefixExpression, MetadataSymbolicReferenceExpression, MetadataSymbolicSelectExpression, MetadataSymbolicSpreadExpression, MetadataValue, MethodMetadata, ModuleExportMetadata, ModuleMetadata, VERSION, isClassMetadata, isConstructorMetadata, isFunctionMetadata, isMetadataError, isMetadataGlobalReferenceExpression, isMetadataSymbolicExpression, isMetadataSymbolicReferenceExpression, isMetadataSymbolicSelectExpression, isMethodMetadata} from './schema';
import {Symbols} from './symbols';

// ModifierFlags introduced in TS 2.1
// TypeScript prior to 2.1 uses the NodeFlags to store modifiers
const isStatic = !!ts.ModifierFlags ?

This comment has been minimized.

Copy link
@imcotton

imcotton Dec 8, 2016

Contributor

If set minimum dependency to TS v2.1, then these checking does not necessary.

This comment has been minimized.

Copy link
@alexeagle

alexeagle Dec 8, 2016

Author Contributor

But Angular 2.x needs to support TypeScript 1.8 because of semver.

This comment has been minimized.

Copy link
@imcotton

imcotton Dec 8, 2016

Contributor

Oh I see, it's devDependencies in package.json, so there could be a test scenario to simulates TS v1.8 as well?

@imcotton imcotton referenced this pull request Dec 8, 2016

Closed

refactor(tsc-wrapped): organize NodeFlags checker #13081

1 of 3 tasks complete
@alexeagle

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2016

@chadbr

This comment has been minimized.

Copy link

commented Dec 15, 2016

Everyone go on vacation? 😄

@alexeagle

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2016

@chadbr

This comment has been minimized.

Copy link

commented Dec 15, 2016

thanks for the update - angular/tsickle#295

@Martin-Wegner

This comment has been minimized.

Copy link

commented Jan 3, 2017

Any news?

@alexeagle

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2017

We are making progress on a TS 2.1 branch of tsickle right now.

@mmc41

This comment has been minimized.

Copy link

commented Jan 10, 2017

@alexeagle According to the angular changelog typescript 2.1 support came in 2.4.2 or was that only partial support ?

@alexeagle alexeagle force-pushed the alexeagle:ts2.1 branch from f5adeb8 to 422cf12 Feb 8, 2017

@googlebot googlebot added cla: yes and removed cla: no labels Feb 8, 2017

build: remove post-processing of .d.ts files
Note that the duplication in tsconfig.json files will be fixed in a followup CL now that we have tsconfig inheritance

BREAKING CHANGE: Angular 4 will support only TypeScript 2.1, so we no longer provide backwards compatibility to TS 1.8.

@alexeagle alexeagle force-pushed the alexeagle:ts2.1 branch from 422cf12 to 572ff1b Feb 8, 2017

@alexeagle

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2017

updated to subsume #14287 for ts-api-guardian

@alexeagle alexeagle force-pushed the alexeagle:ts2.1 branch from 572ff1b to 5de2675 Feb 8, 2017

@alexeagle alexeagle force-pushed the alexeagle:ts2.1 branch from 5de2675 to aef7bc6 Feb 8, 2017

mhevery added a commit that referenced this pull request Feb 8, 2017

mhevery added a commit that referenced this pull request Feb 8, 2017

build: remove post-processing of .d.ts files (#13294)
Note that the duplication in tsconfig.json files will be fixed in a followup CL now that we have tsconfig inheritance

BREAKING CHANGE: Angular 4 will support only TypeScript 2.1, so we no longer provide backwards compatibility to TS 1.8.

mhevery added a commit that referenced this pull request Feb 8, 2017

@mhevery mhevery closed this in 7a4c255 Feb 8, 2017

@noomorph noomorph referenced this pull request Feb 22, 2017

Open

Compilation errors in @types/jasmine v.2.5.42 #14569

4 of 4 tasks complete

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

build: remove post-processing of .d.ts files (angular#13294)
Note that the duplication in tsconfig.json files will be fixed in a followup CL now that we have tsconfig inheritance

BREAKING CHANGE: Angular 4 will support only TypeScript 2.1, so we no longer provide backwards compatibility to TS 1.8.

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

build: remove post-processing of .d.ts files (angular#13294)
Note that the duplication in tsconfig.json files will be fixed in a followup CL now that we have tsconfig inheritance

BREAKING CHANGE: Angular 4 will support only TypeScript 2.1, so we no longer provide backwards compatibility to TS 1.8.

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.