Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent strictNullChecks support until #15432 is fixed #15434

Merged
merged 2 commits into from Mar 23, 2017

Conversation

Projects
None yet
4 participants
@IgorMinar
Copy link
Member

commented Mar 23, 2017

No description provided.

@googlebot googlebot added the cla: yes label Mar 23, 2017

@IgorMinar IgorMinar force-pushed the IgorMinar:disable-strictNullChecks branch 2 times, most recently from 8f1adb0 to e1269b1 Mar 23, 2017

@IgorMinar IgorMinar force-pushed the IgorMinar:disable-strictNullChecks branch from e1269b1 to 96dbd7f Mar 23, 2017

@@ -7,7 +7,8 @@
"compilerOptions": {
"module": "es2015",
"moduleResolution": "node",
"strictNullChecks": true,
// TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432

This comment has been minimized.

Copy link
@DzmitryShylovich

DzmitryShylovich Mar 23, 2017

Contributor

afaik // comments are not allowed in JSON

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Mar 23, 2017

Author Member

tsc allows it

This comment has been minimized.

Copy link
@DzmitryShylovich

DzmitryShylovich Mar 23, 2017

Contributor

hmm you are right microsoft/TypeScript#5450
interesting, thanks :)

@vicb vicb merged commit b800a0c into angular:master Mar 23, 2017

2 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
code-review/pullapprove Approval required by groups: integration, build-and-ci, platform-server, core
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.