refactor(dart/transform): Use render Compiler concepts #1645

Merged
merged 1 commit into from May 6, 2015

Conversation

Projects
None yet
5 participants
@kegluneq
Contributor

kegluneq commented May 2, 2015

Update TemplateCompiler transform step to use abstractions used by the
render Compiler. For example, template code is now loaded via an
instance of TemplateLoader and external resources are fetched via an
instance of XHR.

@vsavkin vsavkin added the in progress label May 2, 2015

@googlebot googlebot added the cla: yes label May 2, 2015

@mhevery mhevery added this to the M10: Sugar milestone May 5, 2015

@kegluneq kegluneq modified the milestones: Dart: M0 Transformers, M10: Sugar May 5, 2015

@kegluneq

This comment has been minimized.

Show comment
Hide comment
@kegluneq

kegluneq May 5, 2015

Contributor

Updated to M0 -- this is necessary for generating change detector classes

Contributor

kegluneq commented May 5, 2015

Updated to M0 -- this is necessary for generating change detector classes

- RecordingReflectionCapabilities _processTemplate(String templateCode) {
+ Future<RecordingReflectionCapabilities> _processTemplate(
+ ViewDefinition viewDef) async {
+ // TODO(kegluneq): Should this be possible?

This comment has been minimized.

@yjbanov

yjbanov May 6, 2015

Contributor

Yes, the so called "imperative views" do not have templates. Instead they build HTML DOM imperatively using "renderers".

@yjbanov

yjbanov May 6, 2015

Contributor

Yes, the so called "imperative views" do not have templates. Instead they build HTML DOM imperatively using "renderers".

+library angular2.transform.template_compiler.xhr_impl;
+
+import 'dart:async';
+import "package:angular2/src/services/xhr.dart" show XHR;

This comment has been minimized.

@yjbanov

yjbanov May 6, 2015

Contributor

Let's use single quotes for consistency

@yjbanov

yjbanov May 6, 2015

Contributor

Let's use single quotes for consistency

refactor(dart/transform): Use render Compiler concepts
Update `TemplateCompiler` transform step to use abstractions used by the
render `Compiler`. For example, template code is now loaded via an
instance of `TemplateLoader` and external resources are fetched via an
instance of `XHR`.

@kegluneq kegluneq merged commit 169e4e8 into angular:master May 6, 2015

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vsavkin vsavkin removed the in progress label May 6, 2015

@kegluneq kegluneq deleted the kegluneq:transitive_meta branch May 6, 2015

vicb added a commit to vicb/angular that referenced this pull request Sep 16, 2016

vicb added a commit to vicb/angular that referenced this pull request Sep 16, 2016

vicb added a commit to vicb/angular that referenced this pull request Sep 16, 2016

vicb added a commit to vicb/angular that referenced this pull request Sep 16, 2016

alexeagle added a commit that referenced this pull request Sep 19, 2016

@lacolaco lacolaco referenced this pull request Sep 23, 2016

Merged

chore(CHANGELOG): fix wrong issue link #11871

1 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment