feat(compiler): add location note to extracted xliff2 files #16791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
force-pushed
the
feature-xliff2-source-16531
branch
from
27e88a8
to
7237cb8
Compare
vicb
reviewed
May 15, 2017
| @@ -88,17 +88,25 @@ const EXPECTED_XLIFF2 = `<?xml version="1.0" encoding="UTF-8" ?> | |||
| <notes> | |||
| <note category="description">desc</note> | |||
| <note category="meaning">meaning</note> | |||
| <note category="location">src/basic.ts:1</note> | |||
There was a problem hiding this comment.
could you add a link to the spec in the commit message
|
LGTM if this conforms to the spec, please add a link in the commit message |
vicb
added
area: i18n
action: cleanup
ocombe
force-pushed
the
feature-xliff2-source-16531
branch
from
7237cb8
to
4c29acb
Compare
ocombe
added
action: review
vicb
added
the
action: cleanup
ocombe
force-pushed
the
feature-xliff2-source-16531
branch
from
4c29acb
to
b49d480
Compare
Add source location as a note tag as `<note category="location">path/to/file.ts:start_line[,end_line]</note>`. `[,end_line]` part is optional and specified only if the end line is different from the start line. Fixes angular#16531
ocombe
force-pushed
the
feature-xliff2-source-16531
branch
from
b49d480
to
978028b
Compare
vicb
approved these changes
May 18, 2017
vicb
added
action: merge
ocombe
changed the title
tbosch
approved these changes
May 22, 2017
panuruj
reviewed
May 22, 2017
|
|
||
| if (message.description || message.meaning) { | ||
| const notes = new xml.Tag('notes'); |
There was a problem hiding this comment.
@ocombe According to the XLIFF 2.0 spec, <notes> must have one or more <note> element. So, an empty <notes> is not valid according to the schema.
http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#notes
You can use this schema validator for testing.
http://okapi-lynx.appspot.com/validation
There was a problem hiding this comment.
it will never be empty since it will contain the url of the source file
There was a problem hiding this comment.
Hmm... I guess the location will never be empty. This would be okay...
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…16791) Add source location as a note tag as `<note category="location">path/to/file.ts:start_line[,end_line]</note>`. `[,end_line]` part is optional and specified only if the end line is different from the start line. Fixes angular#16531
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…16791) Add source location as a note tag as `<note category="location">path/to/file.ts:start_line[,end_line]</note>`. `[,end_line]` part is optional and specified only if the end line is different from the start line. Fixes angular#16531
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Jan 31, 2020
If ngcc gets updated to a new version then the artifacts left in packages that were processed by the previous version are possibly invalid. Previously we just errored if we found packages that had already been processed by an outdated version. Now we automatically clean the packages that have outdated artifacts so that they can be reprocessed correctly with the current ngcc version. Fixes angular#16791
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Jan 31, 2020
If ngcc gets updated to a new version then the artifacts left in packages that were processed by the previous version are possibly invalid. Previously we just errored if we found packages that had already been processed by an outdated version. Now we automatically clean the packages that have outdated artifacts so that they can be reprocessed correctly with the current ngcc version. Fixes angular#16791
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Jan 31, 2020
If ngcc gets updated to a new version then the artifacts left in packages that were processed by the previous version are possibly invalid. Previously we just errored if we found packages that had already been processed by an outdated version. Now we automatically clean the packages that have outdated artifacts so that they can be reprocessed correctly with the current ngcc version. Fixes angular#16791
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Jan 31, 2020
If ngcc gets updated to a new version then the artifacts left in packages that were processed by the previous version are possibly invalid. Previously we just errored if we found packages that had already been processed by an outdated version. Now we automatically clean the packages that have outdated artifacts so that they can be reprocessed correctly with the current ngcc version. Fixes angular#16791
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Jan 31, 2020
If ngcc gets updated to a new version then the artifacts left in packages that were processed by the previous version are possibly invalid. Previously we just errored if we found packages that had already been processed by an outdated version. Now we automatically clean the packages that have outdated artifacts so that they can be reprocessed correctly with the current ngcc version. Fixes angular#16791
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Jan 31, 2020
If ngcc gets updated to a new version then the artifacts left in packages that were processed by the previous version are possibly invalid. Previously we just errored if we found packages that had already been processed by an outdated version. Now we automatically clean the packages that have outdated artifacts so that they can be reprocessed correctly with the current ngcc version. Fixes angular#16791
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
When we added the xliff2 serializer, we forgot to add the source location at the same time because both PR were merged at about the same time.
See #16531
What is the new behavior?
This PR adds a note with the location of source files to the xliff2 units of extracted files.
Does this PR introduce a breaking change?