New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update zone.js to 0.8.10 and expose the flush method #16860

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
6 participants
@juliemr
Member

juliemr commented May 18, 2017

flush() can now be used from within fakeAsync tests to simulate moving
time forward until all macrotask events have been cleared from the
event queue.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@juliemr juliemr self-assigned this May 18, 2017

@juliemr juliemr requested review from vikerman and vicb May 18, 2017

@googlebot googlebot added the cla: yes label May 18, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins May 18, 2017

The angular.io preview for 063929a is available here.

mary-poppins commented May 18, 2017

The angular.io preview for 063929a is available here.

@juliemr

This comment has been minimized.

Show comment
Hide comment
@juliemr

juliemr May 18, 2017

Member

I don't understand why ./node_modules/.bin/gulp public-api:update isn't doing anything. Any ideas?

EDIT: resolved, see #16859

Member

juliemr commented May 18, 2017

I don't understand why ./node_modules/.bin/gulp public-api:update isn't doing anything. Any ideas?

EDIT: resolved, see #16859

@juliemr juliemr changed the title from feat(testing): update zone.js to 0.8.10 and expose the flush method to feat(core): update zone.js to 0.8.10 and expose the flush method May 18, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins May 18, 2017

The angular.io preview for e1cbe59 is available here.

mary-poppins commented May 18, 2017

The angular.io preview for e1cbe59 is available here.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins May 18, 2017

The angular.io preview for d310bc1 is available here.

mary-poppins commented May 18, 2017

The angular.io preview for d310bc1 is available here.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins May 18, 2017

The angular.io preview for 513efa0 is available here.

mary-poppins commented May 18, 2017

The angular.io preview for 513efa0 is available here.

feat(core): update zone.js to 0.8.10 and expose the flush method
`flush()` can now be used from within fakeAsync tests to simulate moving
time forward until all macrotask events have been cleared from the
event queue.
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins May 18, 2017

The angular.io preview for b040f1b is available here.

mary-poppins commented May 18, 2017

The angular.io preview for b040f1b is available here.

@chuckjaz chuckjaz merged commit 85d4c4b into angular:master May 22, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
code-review/pullapprove Approved by all reviewer groups.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

feat(core): update zone.js to 0.8.10 and expose the flush method (#16860
)

`flush()` can now be used from within fakeAsync tests to simulate moving
time forward until all macrotask events have been cleared from the
event queue.

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

feat(core): update zone.js to 0.8.10 and expose the flush method (#16860
)

`flush()` can now be used from within fakeAsync tests to simulate moving
time forward until all macrotask events have been cleared from the
event queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment