New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tsc-wrapped): always convert index shorthand imports #16898

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
6 participants
@DevVersion
Member

DevVersion commented May 19, 2017

What kind of change does this PR introduce? (check one with "x")

[X] Feature

What is the current behavior? (You can also link to an open issue here)

Index shorthand imports are currently only converted when targeting ES2015

What is the new behavior?

Index shorthand imports will be converted always.

Does this PR introduce a breaking change? (check one with "x")

  • You may consider this as breaking.

Now converts shorthand imports for every TypeScript target. Tsickle is able to expand index shorthand imports for every TypeScript target and module possibility.

Expanding shorthand imports for CommonJS modules is also helpful when testing in the browser. Module loaders like SystemJS are not able to understand directory imports (or index shorthand imports)

cc. @alexeagle @jelbourn

feat(tsc-wrapped): always convert shorthand imports
Now converts shorthand imports for every TypeScript target. Tsickle is able to expand index shorthand imports for every TypeScript target and module possibility.

Expanding shorthand imports for CommonJS modules is also helpful when testing in the browser. Module loaders like SystemJS are not able to understand directory imports (or index shorthand imports)

@jelbourn jelbourn requested a review from alexeagle May 19, 2017

@jelbourn

This comment has been minimized.

Show comment
Hide comment
@jelbourn

jelbourn May 22, 2017

Member

@alexeagle does someone else need to review this as well?

Member

jelbourn commented May 22, 2017

@alexeagle does someone else need to review this as well?

@vicb vicb merged commit ea8a43d into angular:master May 30, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
code-review/pullapprove Approved by alexeagle
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DevVersion DevVersion deleted the DevVersion:fix/always-convert-shorthands branch May 30, 2017

asnowwolf added a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017

feat(tsc-wrapped): always convert shorthand imports (#16898)
Now converts shorthand imports for every TypeScript target. Tsickle is able to expand index shorthand imports for every TypeScript target and module possibility.

Expanding shorthand imports for CommonJS modules is also helpful when testing in the browser. Module loaders like SystemJS are not able to understand directory imports (or index shorthand imports)

juleskremer added a commit to juleskremer/angular that referenced this pull request Aug 28, 2017

feat(tsc-wrapped): always convert shorthand imports (#16898)
Now converts shorthand imports for every TypeScript target. Tsickle is able to expand index shorthand imports for every TypeScript target and module possibility.

Expanding shorthand imports for CommonJS modules is also helpful when testing in the browser. Module loaders like SystemJS are not able to understand directory imports (or index shorthand imports)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment