feat: import of @angular/service-worker #17276

alxhub · 2017-06-06T20:42:41Z

Imports the existing repository (without history) from
https://github.com/angular/mobile-toolkit. Sets up the
package to build using build.sh and to run unit tests
as part of test.sh. An integration test is also added,
wrapping the SW e2e test so that npm run test works.

…ular#16860) `flush()` can now be used from within fakeAsync tests to simulate moving time forward until all macrotask events have been cleared from the event queue.

…16791) Add source location as a note tag as `<note category="location">path/to/file.ts:start_line[,end_line]</note>`. `[,end_line]` part is optional and specified only if the end line is different from the start line. Fixes angular#16531

Fixes angular#16919 Fixes angular#16918

closes angular#16110

…filePath (angular#16832). The goal of this change is to simplify the emitters, as we will soon create a new one to emit TypeScript nodes directly.

This is in preparation for creating typescript nodes directly from `OutputAst` nodes.

Using the global reflector made it impossible to compile multiple programs at the same time.

AOT compilation can be executed synchronously now, if the `ReosurceLoader` returns a string directly (and no `Promise`).

This is required as e.g. `token` from `@Inject` is accessed in string form via makeParamDecorator but as a property in the `ReflectiveInjector`. Closes angular#16889 as this is a more general fix.

…angular#16222) Fixes angular#15424

…es (angular#16222)

…ry files (angular#16963) These files are needed so that: - user code can compile even without real codegen - as tsc transformers cannot create but only change existing files in the transformation pipeline.

Fixes angular#16939

If there is a `TopBarNarrow` nav view then use this when the screen is narrow. Otherwise just use the normal `TopBar`. This commit also creates such a narrow topbar view where the "Docs" item is in a different position Closes angular#16940

* refactor(aio): use explicit CSS class for TOC container This makes the styling less fragile to changes in the HTML * fix(aio): schedule TocComponent.activeIndex updates via AsapScheduler We use the `asap` scheduler because updates to `activeItemIndex` are triggered by DOM changes, which, in turn, are caused by the rendering that happened due to a ChangeDetection. Without asap, we would be updating the model while still in a ChangeDetection handler, which is disallowed by Angular. * refactor(aio): do not instantiate floating ToC if not displayed * feat(aio): display the h1 at the top of the floating TOC Closes angular#16900 * refactor(aio): combine the TOC booleans flags into a "type" state * refactor(aio): remove unnecessary `hostElement` property * fix(aio): ensure that transition works on TOC * fix(aio): use strict equality in ToC template

…s them. (angular#16899) This is especially important for library authors, as they will not reference the .ngfactory.ts files. Fixes angular#16741

…6997)

…creen (angular#17001) The `TopBarNarrow` now only shows a single top level container, "About Angular", and the original `TopBar` items will be children of this container. The `TopBarNarrow` styling is changed to match the rest of the `SideNav`.

…nts (angular#17003)

…ngular#17028)

this means we'll be temporarily duplicating the helpers (onces included via scripts and secondly imported via es imports) - once rxjs, core and material migrate over to tslib, we can drop the scripts/global dupe.

mary-poppins · 2017-06-30T18:41:02Z

You can preview b267b24 at https://pr17276-b267b24.ngbuilds.io/.

mary-poppins · 2017-06-30T19:54:25Z

You can preview 1b30a81 at https://pr17276-1b30a81.ngbuilds.io/.

googlebot · 2017-07-04T19:50:38Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

mary-poppins · 2017-07-04T20:05:17Z

You can preview 5c3f29a at https://pr17276-5c3f29a.ngbuilds.io/.

mary-poppins · 2017-07-04T20:26:56Z

You can preview 712c269 at https://pr17276-712c269.ngbuilds.io/.

googlebot · 2017-07-06T05:08:50Z

CLAs look good, thanks!

IgorMinar · 2017-07-06T21:21:56Z

tools/public_api_guard/service-worker/sdk.d.ts

@@ -0,0 +1,284 @@
+/** @experimental */
+export interface BootstrapOptions {


currently we document these within the class/function signature

IgorMinar · 2017-07-06T21:43:55Z

tools/public_api_guard/service-worker/service-worker.d.ts

+
+/** @experimental */
+export declare class NgswModule {
+    static register(script: string, opts?: RegistrationOptions): ModuleWithProviders;


RegistrationOptions doesn't exist. did you forget to inline this type after you removed it?

IgorMinar · 2017-07-06T21:50:15Z

tools/public_api_guard/service-worker/service-worker.d.ts

+    constructor(sw: NgswCommChannel);
+    requestSubscription(options: {
+        serverPublicKey: string;
+    }): Promise<PushSubscription>;


PushSubscription is not a public type. inline or export and prefix with ngsw?

IgorMinar · 2017-07-06T21:58:12Z

tools/public_api_guard/service-worker/service-worker.d.ts

+export declare class NgswUpdate {
+    readonly activated: Observable<NgswUpdateActivatedEvent>;
+    readonly available: Observable<NgswUpdateAvailableEvent>;
+    readonly version: Observable<NgswAppVersion | null>;


could we rename this to currentVersion?

IgorMinar · 2017-07-07T23:21:29Z

@alxhub can you rebase this PR plz?

jo3d3v · 2017-08-28T07:45:12Z

Is this PR planned for angular 5 or later? It would be nice to know, when mobile toolkit (or parts) is merged in the main repo. I plan to build up different PWAs on that module.
While playing with mobile toolkit I identified different enhancements or extensions. (Posted in angular/mobile-toolkit#138 (comment)) I would like to support this ideas with appropriate PRs on that module.

somombo · 2017-10-01T09:36:05Z

In light of #19274 is this PR still in the works?

angular-automatic-lock-bot · 2019-09-12T17:52:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

juliemr and others added 30 commits May 22, 2017 12:19

feat(core): update zone.js to 0.8.10 and expose the flush method (ang…

85d4c4b

…ular#16860) `flush()` can now be used from within fakeAsync tests to simulate moving time forward until all macrotask events have been cleared from the event queue.

fix(animations): repair flicker issues with WA polyfill (angular#16937)

e7d9fd8

Fixes angular#16919 Fixes angular#16918

docs: update the release schedule (angular#16942)

78e3be1

docs: update the release schedule (angular#16943)

f5b2ce0

feat(aio): add progress bar

368169d

closes angular#16110

test(aio): avoid warnings from Material during tests

3b28c75

refactor(compiler): make OutputAst contain the moduleName, not the …

6123b9c

…filePath (angular#16832). The goal of this change is to simplify the emitters, as we will soon create a new one to emit TypeScript nodes directly.

refactor(compiler): emit OutputAst and not sources (angular#16832)

de8d7c6

This is in preparation for creating typescript nodes directly from `OutputAst` nodes.

refactor(compiler): don’t rely on global reflector (angular#16832)

50abca4

Using the global reflector made it impossible to compile multiple programs at the same time.

ci: add vicb as owner to compiler-cli (angular#16832)

255d722

refactor(compiler): allow sync AOT compilation (angular#16832).

5af143e

AOT compilation can be executed synchronously now, if the `ReosurceLoader` returns a string directly (and no `Promise`).

fix(core): make decorators closure safe (angular#16905)

a80ac0a

This is required as e.g. `token` from `@Inject` is accessed in string form via makeParamDecorator but as a property in the `ReflectiveInjector`. Closes angular#16889 as this is a more general fix.

fix(compiler): do not report type errors for arguments with @Inject (…

27761b4

…angular#16222) Fixes angular#15424

fix(tsc-wrapped): ignore |null and |undefined when collecting typ…

1651a8f

…es (angular#16222)

build: import tslib rather than output TS helpers (angular#16901)

fa809ec

refactor(compiler): add ability to produce stub .ngfactory / .ngsumma…

eba59aa

…ry files (angular#16963) These files are needed so that: - user code can compile even without real codegen - as tsc transformers cannot create but only change existing files in the transformation pipeline.

fix(aio): align top-level nav-items consistently

9e17a14

Fixes angular#16939

build(aio): better error message for invalid links (angular#16993)

b0c5018

fix(compiler): compile .ngfactory.ts files even if nobody reference…

573b861

…s them. (angular#16899) This is especially important for library authors, as they will not reference the .ngfactory.ts files. Fixes angular#16741

fix(aio): correctly handle re-navigation to the empty path (angular#1…

e10d763

…6997)

build(aio): less verbose boilerplate generator (angular#16970)

4c5e28e

docs(aio): restore missing files (angular#16995)

b37a048

fix(animations): use a lightweight renderer for non-animation compone…

3ab86bd

…nts (angular#17003)

refactor(compiler): change bundle to flatModuleIndex in the code (a…

5aa53d7

…ngular#17028)

build(aio): start using tsc importHelpers option for the app

0c691af

this means we'll be temporarily duplicating the helpers (onces included via scripts and secondly imported via es imports) - once rxjs, core and material migrate over to tslib, we can drop the scripts/global dupe.

build(aio): upgrade ngo to 0.0.3 with static prop unhoisting

7404502

alxhub force-pushed the service-worker branch from b267b24 to 1b30a81 Compare June 30, 2017 19:38

alxhub force-pushed the service-worker branch from 1b30a81 to baa5e28 Compare June 30, 2017 20:29

feat: use flux standard actions for worker <-> client communication

6fe895e

alxhub force-pushed the service-worker branch from baa5e28 to 6fe895e Compare June 30, 2017 21:42

googlebot added cla: no and removed cla: yes labels Jul 4, 2017

alxhub force-pushed the service-worker branch from 5c3f29a to 712c269 Compare July 4, 2017 20:10

alxhub force-pushed the service-worker branch from 712c269 to 1f33372 Compare July 6, 2017 03:35

refactor: address comments in code review

b25b0b7

alxhub force-pushed the service-worker branch from 1f33372 to b25b0b7 Compare July 6, 2017 05:08

googlebot added cla: yes and removed cla: no labels Jul 6, 2017

IgorMinar suggested changes Jul 7, 2017

View reviewed changes

IgorMinar added the state: blocked label Jul 7, 2017

mgechev mentioned this pull request Jul 10, 2017

CLI does not provide --mobile option anymore angular/mobile-toolkit#170

Closed

mhevery force-pushed the master branch from 08b36cb to 5d4b36f Compare July 20, 2017 21:49

somombo mentioned this pull request Sep 7, 2017

Future of mobile-toolkit for angular v4+ and cli v1+ angular/mobile-toolkit#138

Closed

BorntraegerMarc mentioned this pull request Sep 30, 2017

Feature request: testable service workers angular/protractor#4514

Open

alxhub closed this Oct 4, 2017

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: import of @angular/service-worker #17276

feat: import of @angular/service-worker #17276

alxhub commented Jun 6, 2017

mary-poppins commented Jun 30, 2017

mary-poppins commented Jun 30, 2017

googlebot commented Jul 4, 2017

mary-poppins commented Jul 4, 2017

mary-poppins commented Jul 4, 2017

googlebot commented Jul 6, 2017

IgorMinar Jul 6, 2017

IgorMinar Jul 6, 2017

IgorMinar Jul 6, 2017

IgorMinar Jul 6, 2017

IgorMinar commented Jul 7, 2017

jo3d3v commented Aug 28, 2017

somombo commented Oct 1, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

		@@ -0,0 +1,284 @@
		/** @experimental */
		export interface BootstrapOptions {

Navigation Menu

feat: import of @angular/service-worker #17276

feat: import of @angular/service-worker #17276

Conversation

alxhub commented Jun 6, 2017

mary-poppins commented Jun 30, 2017

mary-poppins commented Jun 30, 2017

googlebot commented Jul 4, 2017

mary-poppins commented Jul 4, 2017

mary-poppins commented Jul 4, 2017

googlebot commented Jul 6, 2017

IgorMinar Jul 6, 2017

Choose a reason for hiding this comment

IgorMinar Jul 6, 2017

Choose a reason for hiding this comment

IgorMinar Jul 6, 2017

Choose a reason for hiding this comment

IgorMinar Jul 6, 2017

Choose a reason for hiding this comment

IgorMinar commented Jul 7, 2017

jo3d3v commented Aug 28, 2017

somombo commented Oct 1, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019