Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler): don’t always compile `.ngfactory.ts` files by def… #17439

merged 1 commit into from Jun 12, 2017


Copy link

tbosch commented Jun 12, 2017


This puts the behavior introduced in 573b861 behind the new flag
alwaysCompileGeneratedCode to not break users that might have relied
on this behavior.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:


This puts the behavior introduced in 573b861 behind the new flag
`alwaysCompileGeneratedCode` to not break users that might have relied
on this behavior.
@googlebot googlebot added the cla: yes label Jun 12, 2017
Copy link

mary-poppins commented Jun 12, 2017

The preview for fb736ba is available here.

@alxhub alxhub merged commit ed73d4f into angular:master Jun 12, 2017
3 of 4 checks passed
3 of 4 checks passed
ci/circleci Your tests failed on CircleCI
cla/google All necessary CLAs are signed
code-review/pullapprove Approved by all reviewer groups.
continuous-integration/travis-ci/pr The Travis CI build passed
@tbosch tbosch deleted the tbosch:flagcompile branch Aug 14, 2017
Copy link

angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.