fix(forms): temp roll back breaking change with min/max directives #17551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. Closes angular#17491.
kara
added
the
action: review
IgorMinar
approved these changes
Jun 16, 2017
IgorMinar
removed
the
action: review
hansl
added a commit
to hansl/angular
that referenced
this pull request
Jun 19, 2017
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives. Closes angular#17491. ---- PR angular#17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used. This PR rolls back the original PR and commit the same as angular#17551 while also removing the dead code.
hansl
added a commit
to hansl/angular
that referenced
this pull request
Jun 19, 2017
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives. Closes angular#17491. ---- PR angular#17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used. This PR rolls back the original PR and commit the same as angular#17551 while also removing the dead code.
hansl
added a commit
to hansl/angular
that referenced
this pull request
Jun 20, 2017
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives. Closes angular#17491. ---- PR angular#17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used. This PR rolls back the original PR and commit the same as angular#17551 while also removing the dead code.
hansl
added a commit
that referenced
this pull request
Jun 20, 2017
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives. Closes #17491. ---- PR #17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used. This PR rolls back the original PR and commit the same as #17551 while also removing the dead code.
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives. Closes angular#17491. ---- PR angular#17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used. This PR rolls back the original PR and commit the same as angular#17551 while also removing the dead code.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives. Closes angular#17491. ---- PR angular#17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used. This PR rolls back the original PR and commit the same as angular#17551 while also removing the dead code.
3 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes.
For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives.
Closes #17491.
cc: @hansl @IgorMinar