New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support for bootstrap with custom zone #17672

Closed
wants to merge 2 commits into
base: master
from

Conversation

@jasonaden
Contributor

jasonaden commented Jun 21, 2017

This PR is based on Misko's PR (#17142), with PR comments addressed.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Jun 21, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot commented Jun 21, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no label Jun 21, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 21, 2017

The angular.io preview for 2fbe119 is available here.

mary-poppins commented Jun 21, 2017

The angular.io preview for 2fbe119 is available here.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 21, 2017

The angular.io preview for c8c6648 is available here.

mary-poppins commented Jun 21, 2017

The angular.io preview for c8c6648 is available here.

@jasonaden jasonaden requested a review from vicb Jun 21, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 21, 2017

The angular.io preview for 75bbe38 is available here.

mary-poppins commented Jun 21, 2017

The angular.io preview for 75bbe38 is available here.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 22, 2017

The angular.io preview for 181e449 is available here.

mary-poppins commented Jun 22, 2017

The angular.io preview for 181e449 is available here.

@vicb

vicb approved these changes Jun 22, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 22, 2017

The angular.io preview for 8a13973 is available here.

mary-poppins commented Jun 22, 2017

The angular.io preview for 8a13973 is available here.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 23, 2017

The angular.io preview for 87ba8a5 is available here.

mary-poppins commented Jun 23, 2017

The angular.io preview for 87ba8a5 is available here.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins Jun 26, 2017

The angular.io preview for 26e804f is available here.

mary-poppins commented Jun 26, 2017

The angular.io preview for 26e804f is available here.

Show outdated Hide outdated tools/public_api_guard/core/core.d.ts
Show outdated Hide outdated packages/core/src/application_ref.ts
Show outdated Hide outdated packages/core/src/zone/ng_zone.ts
@ocombe

This comment has been minimized.

Show comment
Hide comment
@ocombe

ocombe Sep 13, 2017

Contributor

Rebased & refactored based on your comments.

Contributor

ocombe commented Sep 13, 2017

Rebased & refactored based on your comments.

@ocombe ocombe added cla: yes and removed cla: no labels Sep 13, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 13, 2017

@googlebot googlebot added cla: no and removed cla: yes labels Sep 13, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 13, 2017

@ocombe

This comment has been minimized.

Show comment
Hide comment
@ocombe

ocombe Sep 13, 2017

Contributor

I've pushed my code without the change to zone run in the upgrade file, but it fails the tests on travis as expected: https://travis-ci.org/angular/angular/jobs/275139988#L1020

Contributor

ocombe commented Sep 13, 2017

I've pushed my code without the change to zone run in the upgrade file, but it fails the tests on travis as expected: https://travis-ci.org/angular/angular/jobs/275139988#L1020

@ocombe

This comment has been minimized.

Show comment
Hide comment
@ocombe

ocombe Sep 13, 2017

Contributor

The code has been fixed, there was an error in the optionsReducer function which ended up creating 2 NgZone instances (thanks @mhevery for finding where the bug was). I added a test for that as well.

Contributor

ocombe commented Sep 13, 2017

The code has been fixed, there was an error in the optionsReducer function which ended up creating 2 NgZone instances (thanks @mhevery for finding where the bug was). I added a test for that as well.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 13, 2017

on vacation

@matsko

This comment has been minimized.

Show comment
Hide comment
@matsko

matsko Sep 15, 2017

Member

@jasonaden @mhevery please rebase

Member

matsko commented Sep 15, 2017

@jasonaden @mhevery please rebase

@mhevery

This comment has been minimized.

Show comment
Hide comment
@mhevery

mhevery Sep 15, 2017

Member

Actually this is now owned by @ocombe and he said he will rebase.

Member

mhevery commented Sep 15, 2017

Actually this is now owned by @ocombe and he said he will rebase.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 15, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 15, 2017

@IgorMinar

This comment has been minimized.

Show comment
Hide comment
@IgorMinar

IgorMinar Sep 20, 2017

Member

can you please rebase?

Member

IgorMinar commented Sep 20, 2017

can you please rebase?

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 21, 2017

@ocombe

This comment has been minimized.

Show comment
Hide comment
@ocombe

ocombe Sep 21, 2017

Contributor

Rebased!

Contributor

ocombe commented Sep 21, 2017

Rebased!

@googlebot googlebot added cla: no and removed cla: yes labels Sep 21, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Sep 21, 2017

@IgorMinar IgorMinar added cla: yes and removed cla: no labels Sep 21, 2017

@IgorMinar IgorMinar closed this in 344a5ca Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment