Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(http): fix "Expecting and answering requests" example mistake #18157

Merged
merged 1 commit into from Jul 17, 2017

Conversation

@happycollision
Copy link
Contributor

@happycollision happycollision commented Jul 16, 2017

Simple fix for possible mistake in docs.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The test example looks like this:

http
  .get('/data')
  .subscribe(data => expect(data['name']).toEqual('Test Data'));

. . .

  const req = httpMock.expectOne('/test');

Issue Number: N/A

What is the new behavior?

The test example looks like this:

http
  .get('/data')
  .subscribe(data => expect(data['name']).toEqual('Test Data'));

. . .

  const req = httpMock.expectOne('/data');

The final line above is the one in question.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Possibly overlooked testing documentation mistake fixed:
- `http.get('/data')` probably ought to be paired with `httpMock.expectOne('/data')` instead of `httpMock.expectOne('/data')`.
@googlebot
Copy link

@googlebot googlebot commented Jul 16, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
@happycollision
Copy link
Contributor Author

@happycollision happycollision commented Jul 16, 2017

I signed it!

@googlebot
Copy link

@googlebot googlebot commented Jul 16, 2017

CLAs look good, thanks!

@alxhub
alxhub approved these changes Jul 17, 2017
@alxhub alxhub merged commit 47b3ecd into angular:master Jul 17, 2017
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
@googlebot
cla/google All necessary CLAs are signed
code-review/pullapprove Approved by Foxandxss
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
@happycollision happycollision deleted the happycollision:happycollision-patch-1 branch Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants